The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com
Facter should implement its own which command
|Keywords:||Affected Facter version:|
Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com
This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.
Facter::Util::Resolution.exec relies on
which to check if a command can be executed. This basically means that for every command we want to execute, we fork a second time just to execute which.
Facter should implement its own which command so we don’t need to invoke the shell all the time. Puppet already has some similar methods we may be able to port to facter.
#3 Updated by Stefan Schulte almost 2 years ago
- Category set to library
- Status changed from Unreviewed to In Topic Branch Pending Review
- Assignee deleted (
- Branch changed from https://github.com/stschulte/facter/tree/refactor/1.6.x/13678 to https://github.com/puppetlabs/facter/pull/189
#5 Updated by Jeff Weiss almost 2 years ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Target version set to 1.6.10
#6 Updated by Ken Barber almost 2 years ago
Stefan thanks very much for all your great work on this – its a very awesome change indeed and I appreciate your patience and attitude towards getting this ‘just right’.
Jeff – I don’t know if you have noticed, but there is a number of marked deprecations and warnings in this code that may warrant future deprecation. Not sure when (as in what version) you want to achieve this, but they may warrant tickets for tracking.