« Previous | Next » 

Revision 2ec4e298

ID: 2ec4e298c3274abc8eaad4230bca8d39a48d2e35
Added by Brice Figureau about 1 year ago

Fix #1502 - abysmal storeconfig performance - part2

Resource parameters whose values are a resource reference (ie require,
notify...) where always DELETEd/INSERTed because the code comparing
resource reference compared object instances instead of their values
(since Puppet::Parser::Resource::Reference doesn't override ), leading
to storeconfig performance issues.
The correct fix would have been to define in Puppet::Parser::Resource::Reference
but that might introduce some side effects I don't know.
Hence, the fix introduces a local compare() method that knows how to
compare Puppet::Parser::Resource::Reference.

Signed-off-by: Brice Figureau <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences