Puppet

On Debian’s 0.25.4-2~bpo50+1, the following fails:

config = Puppet::Util::Settings.new
config.setdefaults(:reports, :basedir => {:default => @hostdir, :owner => :service, :mode => 0755, :desc => "munin report hack"})

with this error:

.....: Internal error: The :owner setting for ...: basedir must be either 'root' or 'service', not 'service'

But this works:

config = Puppet::Util::Settings.new
config.setdefaults(:reports, :basedir => {:default => @hostdir, :owner => 'service', :mode => 0755, :desc => "munin report hack"})

The only difference is ‘service’ instead of :service.

The error occurs in puppet/util/settings/file_setting.rb:

AllowedOwners = %w{root service}
...
    unless AllowedOwners.include?(value)

Here’s the stacktrace starting from my code:

/usr/lib/ruby/1.8/puppet/util/settings/file_setting.rb:33:in `owner='
/usr/lib/ruby/1.8/puppet/util/settings/setting.rb:44:in `send'
/usr/lib/ruby/1.8/puppet/util/settings/setting.rb:44:in `initialize'
/usr/lib/ruby/1.8/puppet/util/settings/setting.rb:38:in `each'
/usr/lib/ruby/1.8/puppet/util/settings/setting.rb:38:in `initialize'
/usr/lib/ruby/1.8/puppet/util/settings.rb:405:in `new'
/usr/lib/ruby/1.8/puppet/util/settings.rb:405:in `newsetting'
/usr/lib/ruby/1.8/puppet/util/settings.rb:538:in `setdefaults'
/usr/lib/ruby/1.8/puppet/util/settings.rb:523:in `each'
/usr/lib/ruby/1.8/puppet/util/settings.rb:523:in `setdefaults'

I’d suggest internalizing both the Allowed* arrays and the incoming value.