Bug #2958

inconsistent errors in spec/integration/bin/puppetmasterd.rb

Added by Jesse Wolfe 7 months ago. Updated 7 months ago.

Status:Closed Start:12/18/2009
Priority:Normal Due date:
Assigned to:Jesse Wolfe % Done:

0%
Category:testing
Target version:-
Affected version:0.25.1 Branch:http://github.com/jes5199/puppet/tree/ticket/0.25.x/2958
Keywords:
Votes: 0

Description

I get two different errors in spec/integration/bin/puppetmasterd.rb, depending on what directory I’m in when I launch spec.

from ~/puppet/ : – should be serving status information over REST (PENDING: Not Yet Implemented) ./spec/integration/bin/../../../sbin/puppetmasterd:65:in `require': no such file to load — puppet/application/puppetmasterd (LoadError)

from ./spec/integration/bin/../../../sbin/puppetmasterd:65
  • should be serving status information over xmlrpc (FAILED – 2) ./spec/integration/bin/../../../sbin/puppetmasterd:65:in `require': no such file to load — puppet/application/puppetmasterd (LoadError)

from ~/puppet/lib/ : 1) Puppet::Network::XMLRPCClientError in ‘puppetmasterd should be serving status information over xmlrpc’ Could not connect to localhost on port 12345

Associated revisions

Revision 037b99a27dc8b2aeb44c5cdfb20bfef672294405
Added by Jesse Wolfe 7 months ago

Fixing #2958 inconsistent errors in spec/integration/bin/puppetmasterd.rb

I was getting inconsistent errors in this file, and it’s really two separate issues but they’re both trivial.

1) The spec launches ./sbin/puppetmasterd, which may have trouble finding the puppet libraries. It could even load the system-installed puppet rather than the files in the repository — I think this effect is why the tests were passing on Markus’s machine, for example.

2) There’s a race condition in this test, and puppetmasterd has gotten slower to start up (perhaps due to the #2877 fix?)

Signed-off-by: Jesse Wolfe jes5199@gmail.com

History

Updated by Jesse Wolfe 7 months ago

  • Branch set to http://github.com/jes5199/puppet/tree/ticket/0.25.x/2958

Updated by James Turnbull 7 months ago

  • Category set to testing
  • Status changed from Ready for Testing to Closed

Fixed it for me.

Pushed in commit:“037b99a27dc8b2aeb44c5cdfb20bfef672294405” in branch 0.25.x

Also available in: Atom PDF