Bug #2796

puppetdoc rdoc mode doesn't handle selectors in define parameter values

Added by Kjetil Torgrim Homme 9 months ago. Updated 9 months ago.

Status:Closed Start:11/10/2009
Priority:Normal Due date:
Assigned to:James Turnbull % Done:

0%

Category:documentation
Target version:0.25.2
Affected version:0.25.1 Branch:
Keywords:
Votes: 0

Description

The following code causes problems for the puppetdoc parser:

class modprobe {

define config($local_modprobe="",
              $bonding_mode="balance-tlb",
              $path=$osfamily ? {
                  "redhat" => "/etc/modprobe.conf",
                  "debian" => "/etc/modprobe.d/redpill-linpro",
              })
{
    file { $path:
        content => template("modprobe/modprobe.conf.erb");
    }
}
config { $fqdn: }

}

Here’s the backtrace:

info: rdoc: scanning /var/lib/puppet/svn/modules/modprobe/manifests/init.pp /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:269:in document_define' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:264:ineach' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:264:in document_define' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:308:inparse_elements' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:306:in each' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:306:inparse_elements' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:142:in scan_top_level' /usr/lib/ruby/1.8/puppet/util/rdoc/parser.rb:38:inscan' /usr/lib/ruby/1.8/rdoc/rdoc.rb:226:in parse_files' /usr/lib/ruby/1.8/rdoc/rdoc.rb:219:ineach' /usr/lib/ruby/1.8/rdoc/rdoc.rb:219:in parse_files' /usr/lib/ruby/1.8/rdoc/rdoc.rb:264:indocument' /usr/lib/ruby/1.8/puppet/util/rdoc.rb:31:in rdoc' /usr/lib/ruby/1.8/puppet/application/puppetdoc.rb:83:inrdoc' /usr/lib/ruby/1.8/puppet/application.rb:226:in send' /usr/lib/ruby/1.8/puppet/application.rb:226:inrun_command' /usr/lib/ruby/1.8/puppet/application.rb:217:in run' /usr/lib/ruby/1.8/puppet/application.rb:306:inexit_on_fail' /usr/lib/ruby/1.8/puppet/application.rb:217:in run' /usr/bin/puppetdoc:65 Could not generate documentation: undefined methodvalue' for #<Puppet::Parser::AST::Selector:0x7fa31e897d58>


Related issues

related to Puppet - Bug #2795: puppetdoc parser fails without useful error message Closed 11/10/2009

History

Updated by James Turnbull 9 months ago

  • Category set to documentation
  • Status changed from Unreviewed to Accepted
  • Assigned to set to Brice Figureau
  • Target version set to 0.25.2

Updated by Brice Figureau 9 months ago

  • Status changed from Accepted to Ready for Checkin
  • Assigned to changed from Brice Figureau to James Turnbull

This bug is fixed by the patch in #2795.

Updated by James Turnbull 9 months ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“53be6f81261db1b7a022ec683e1a637cd2c5c93e” in branch master and commit:“38ec9fcc5f3965942a74c8d7b7dfd1cf1796c0df” in branch 0.25.x

Also available in: Atom PDF