Bug #2787

hosts.environment not updating in stor-config db

Added by Allan Marcus 9 months ago. Updated 9 months ago.

Status:Closed Start:11/04/2009
Priority:Normal Due date:
Assigned to:Brice Figureau % Done:

0%

Category:plumbing
Target version:0.25.2
Affected version:0.25.1 Branch:
Keywords:
Votes: 0

Description

I’m not seeing the hosts.environment data field update when I switch environments for a node. The environment fact is correct, but the hosts.environment field is not being updated.

Client and server are Mac OS X. Database is MySQL using puppet 0.25.1 on both sides.

History

Updated by James Turnbull 9 months ago

  • Category set to plumbing
  • Status changed from Unreviewed to Investigating
  • Assigned to set to Brice Figureau

Brice – any ideas?

Updated by Allan Marcus 9 months ago

Ack! the hosts.ip field is also not updating! This is very important to us.

Updated by Brice Figureau 9 months ago

James Turnbull wrote:

Brice – any ideas?

lots :–)

We somehow lost the code between 0.24.8 and 0.25 when Luke refactored the rails host resource merging to use the indirector. I’ll send a patch during the week-end to fix both env and ip.

Updated by Brice Figureau 9 months ago

  • Status changed from Investigating to Ready for Testing

Brice Figureau wrote:

James Turnbull wrote:

Brice – any ideas? [snipped] I’ll send a patch during the week-end to fix both env and ip.

Please find a patch to test in the tickets/0.25.x/2787 branch in my github repository: http://github.com/masterzen/puppet/tree/tickets/0.25.x/2787

Allan: can you check it restores the behavior of 0.24.8?

Updated by Allan Marcus 9 months ago

I see where you made the changes, but I don’t quite understand how to “get a patch” and apply it. I’m new to GIT, so please excuse my ignorance. If you would, can you please walk me through this process once, then I will know how to do it in the future.

Updated by James Turnbull 9 months ago

Allan – just download http://github.com/masterzen/puppet/commit/02b5a4a6232b62902ea04fd9f6911371daa3fa0d.patch and apply that to your Puppet with patch.

Updated by Brice Figureau 9 months ago

Allan Marcus wrote:

I see where you made the changes, but I don’t quite understand how to “get a patch” and apply it. I’m new to GIT, so please excuse my ignorance. If you would, can you please walk me through this process once, then I will know how to do it in the future.

The important part is only 4 lines (the plused ones), so you can add them by hand to the correct file if you prefer.

James solution is certainly the simplest one, but if you want the full git experience:

git clone git://github.com/masterzen/puppet.git masterzen-puppet

cd masterzen-puppet

git checkout tickets/0.25.x/2787

You’re then in a source tree matching 0.25.1 and containing this fix. From there you can:

  • use this tree directly to test the behavior or

  • copy the patched file to your regular puppetmaster and see if that solves the issue

Hope that helps,

Updated by Allan Marcus 9 months ago

The fix seems to work. thanks.

Updated by James Turnbull 9 months ago

  • Status changed from Ready for Testing to Closed

Pushed in commit:“cb3e5e10d76a4a0f44e16c5bf36c69b65ae18fbb” in branch 0.25.x

Updated by James Turnbull 9 months ago

  • Target version set to 0.25.2

Also available in: Atom PDF