Bug #2671

preferred_serialization_format does not complain about invalid values

Added by R.I. Pienaar aka Volcane 10 months ago. Updated 8 months ago.

Status:Closed Start:09/22/2009
Priority:Normal Due date:
Assigned to:James Turnbull % Done:

0%
Category:serialization
Target version:0.25.2
Affected version:0.25.0 Branch:http://github.com/bruce/puppet/tree/ticket/0.25.x/2671
Keywords:
Votes: 0

Description

Puppet should log if you pass bogus formats to preferred_serialization_format rather than silently falling back to yaml.

# puppetd --onetime --test --preferred_serialization_format foo
info: Caching catalog for dev1.pinetecltd.net
info: Applying configuration version '1253646355'
notice: Finished catalog run in 0.20 seconds

History

Updated by James Turnbull 10 months ago

  • Category set to serialization
  • Status changed from Unreviewed to Accepted
  • Target version set to 0.25.2

Updated by Markus Roberts 9 months ago

  • Assigned to set to Bruce Williams

Updated by Bruce Williams 9 months ago

  • Status changed from Accepted to Ready for Testing
  • Assigned to changed from Bruce Williams to Markus Roberts
  • Branch set to http://github.com/bruce/puppet/tree/ticket/0.25.x/2671
This modifies `supported_formats` to warn when the
`preferred_serialization_format` setting is invalid (and ignored in
favor of the default value).

I built the tests for this behavior alongside the existing
FormatHandler tests for *valid* `preferred_serialization_format` values
(and did some restructuring to extract common setup code to `before`
blocks).

Updated by James Turnbull 8 months ago

  • Status changed from Ready for Testing to Ready for Checkin
  • Assigned to changed from Markus Roberts to James Turnbull

Updated by James Turnbull 8 months ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“7f2e5fc51b64d5a9281a7e65a88b378b1c99d03f” in branch 0.25.x

Updated by Peter Meier 8 months ago

Using latest 0.25.x I know get

warning: Value of 'preferred_serialization_format' ('pson') is invalid, using default ('yaml')

maybe because for pson supported? is missing? –> http://github.com/bruce/puppet/blob/a1624d08efeeb9b11da1046177445efebbd32ea7/lib/puppet/network/formats.rb

Updated by Peter Meier 8 months ago

maybe because for pson supported? is missing? –> http://github.com/bruce/puppet/blob/a1624d08efeeb9b11da1046177445efebbd32ea7/lib/puppet/network/formats.rb

could verify that. Open a new bug for that

Also available in: Atom PDF