Bug #2573

fqdn is wrong if nodename is not the first part of fqdn

Added by Benedikt Böhm 11 months ago. Updated 5 months ago.

Status:Closed Start:08/27/2009
Priority:High Due date:
Assigned to:Paul Nasrat % Done:

0%
Category:-
Target version:1.5.8
Keywords: Branch:
Votes: 0

Description

the logic in fqdn.rb is too naive because it does no DNS checks. concatenation of hostname and domainname does not work in case the hostname/nodename is not the same as the first part of the FQDN:

# cat /etc/hosts
78.47.63.169    a.newthinking-ns.de ns1
# hostname
ns1
# hostname -f
a.newthinking-ns.de
# facter | grep fqdn
fqdn => ns1.newthinking-ns.de

this should probably be solved together with bug 2085 by implementing correct dns resolution for fqdn.rb

Associated revisions

Revision dca615c98b864d75e2ac5899d98d04a2bd979eba
Added by Ohad Levy 5 months ago

fixes #2573, #2085, #1291 – fixes domain and fqdn facts resolution

This patch removes the relationship between the domain fact and LDAP/NIS domains. domain fact relates to DNS domain – this will avoid the confusion caused by the LDAP/NIS domain (which might be different to the DNS domain name). Additionally, if hostname is already in long form, it won’t try to build the fqdn fact from hostname and domain.

History

Updated by Benedikt Böhm 11 months ago

  • 3 changed from Unknown to Trivial

pull http://github.com/hollow/facter/commit/ab07f5f7e3ba4bcfa33999ece9080f5bc0bf0c15

Updated by Benedikt Böhm 11 months ago

as a follow up, this should fix all dns problem currently open in facter. i have commented on the other bugs too: http://github.com/hollow/facter/commit/92f6b049724a620f3833dde10b8126a70ce52a08

Updated by Paul Nasrat 11 months ago

  • Status changed from Unreviewed to Ready for Testing
  • Assigned to set to Paul Nasrat
  • Target version set to 1.6.0

Mailed trivial patch to list. See my comment in other bug re external dep in 92f6b049724a620f3833dde10b8126a70ce52a08

Updated by Paul Nasrat 11 months ago

  • Target version changed from 1.6.0 to 1.5.7

Updated by Paul Nasrat 11 months ago

  • Target version changed from 1.5.7 to 1.6.0

Re targetting to 1.6.0 so we can solve all the dns issues in one go.

Updated by James Turnbull 9 months ago

  • Priority changed from Normal to High

Updated by James Turnbull 7 months ago

  • Target version changed from 1.6.0 to 1.5.8

Updated by Paul Nasrat 5 months ago

  • Status changed from Ready for Testing to Ready for Checkin

Updated by Paul Nasrat 5 months ago

  • Status changed from Ready for Checkin to Closed

Commited Ohad’s patch.

Also available in: Atom PDF