Feature #2568

add puppetmasterd 'dbconnections' option to increase rails 'max pool size'

Added by Richard Soderberg 11 months ago. Updated 3 months ago.

Status:Closed Start:08/25/2009
Priority:Normal Due date:
Assigned to:- % Done:

0%
Category:Rails
Target version:2.6.0
Affected version:0.25.4 Branch:
Keywords:rails database connections max pool size
Votes: 2

Description

the attached patch adds a new option ‘dbconnections’ which tells ActiveRecord the max pool size of the rails connection pool when using ‘mysql’ or ‘postgres’ storeconfig.

ref: http://groups.google.com/group/puppet-users/msg/eab8ee9092dd308c ref: http://www.ruby-forum.com/topic/178429

patch includes changes for all files containing the term ‘dbuser’, including docs and tests and a helper utility. i hope that’s enough.

patch is against git as of a few minutes, all changes pulled before producing the diff.

dbconnections.txt - add database option 'dbconnections' that sets the ActiveRecords connection pool size, when connecting to remote databases (mysql, postgres). default is 0; the 'pool' argument is only passed to ActiveRecords when the value is 1 or greater. (4.1 KB) Richard Soderberg, 11/19/2009 09:01 pm

Associated revisions

Revision c9f40be6c567d8de328b9d79dde357672323925a
Added by Richard Soderberg 8 months ago

Fixed #2568 – Add database option ‘dbconnections’

This sets the ActiveRecords connection pool size, when connecting to remote databases (mysql, postgres). default is 0; the ‘pool’ argument is only passed to ActiveRecords when the value is 1 or greater.

History

Updated by James Turnbull 11 months ago

  • Status changed from Unreviewed to Needs design decision
  • Assigned to set to Luke Kanies

Updated by Luke Kanies 11 months ago

  • Status changed from Needs design decision to Ready for Testing
  • Assigned to deleted (Luke Kanies)
  • Target version set to 2.6.0

Updated by James Turnbull 8 months ago

  • Status changed from Ready for Testing to Code Insufficient

Can you please rebase this patch against current master HEAD.

Updated by Richard Soderberg 8 months ago

  • File patch added

done, also submitted pull request through github

Updated by Richard Soderberg 8 months ago

  • File deleted (patch)

Updated by Richard Soderberg 8 months ago

  • File deleted (dbconnections.txt)

Updated by Richard Soderberg 8 months ago

patch applies cleanly to 2d137e2e1ce603ee2727d66b1aba57458bf4d1be

Updated by James Turnbull 8 months ago

  • Status changed from Code Insufficient to Ready for Testing

Pushed to -dev list for comment.

Updated by James Turnbull 8 months ago

  • Status changed from Ready for Testing to Closed

Pushed in commit:“c9f40be6c567d8de328b9d79dde357672323925a” in branch master.

Updated by micah - 4 months ago

  • Affected version changed from 0.24.8 to 0.25.4

I’m getting this now fairly regularly on 0.25.4, I’ve tried to space out my clients hitting the puppetmaster as much as possible, but it seems like I’ve optimized that as far as I can. It would be nice if I could bump up this parameter much sooner than rowlf… any chance this could be targetted for 0.25.5?

Oh, I also setup puppetqd+stompserver, but that doesn’t seem to be enough, as I am still getting it.

Also available in: Atom PDF