Puppet » Facter

I’ll try to have a shot a it tomorrow at work.

I have forked facter on github and sent a pull request to jamtur01 and reductivelabs, in the hope that it will reach whom it may concern. Commit is here http://github.com/thegcat/facter/commit/082bd1eb12b61b18d3dab4ff6b70bbcf9eb705b0

I reviewed this on list, but I’m updating this to get to the original patch author. i

Generally if we’re doing more complex facts we should have tests.

Also the patch as is won’t work as it’s doing assignment (single equals) in conditionals not comparison (==).

If you can fix up the logic and update this bug that’d be great, if you want advise on how to test please ask on the dev list.

It looks like this started with a discussion on the mailing list which led to an insufficient patch, but it hasn’t been improved? Is anyone taking ownership of this one?

I should – it’s originally my code.

We have a number of branches that have very different approaches to solving this bug. I have a proposal:

Uptime should be computed using the most accurate and easiest to parse method available on the underlying system, starting with /proc/uptime on systems that have it. It should only be computed once and this computed value should be used for all facts that depend upon it.

I’m happy to work on a patch that addresses these concerns and will update once I have one.

Available in my github (reinh) at 2330-uptime-gets-computed-twice-on-systems-with-/proc/uptime

Updated my branch to use bin/cat proc/uptime because of #4466

Updating branch name.

Closing: merged into master and available in 1.5.8rc1.