Bug #2328
Whitespace cleanup
| Status: | Closed | Start: | 06/05/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | % Done: | 0% |
||
| Category: | plumbing | |||
| Target version: | 0.25.0 | |||
| Affected version: | 0.24.8 | Branch: | ||
| Keywords: | ||||
| Votes: | 1 |
Description
There would be too many patches to clean this up for each file individually.
h3. I have split this up into 3 patches
Go from tabs to spaces without destroying alignment or indentation
Fix indentation to the correct number of spaces per level as specified by the style guide
Remove dangling whitespace at the end of lines
These should patch cleanly against commit @00d5139639afe9b206f2f68df95cebfeb28f28b1@
Once applied with @git apply@, @git diff -w@ should confirm that the changes are to whitespace only (with exceptions of files that had no newline on the last line, those were added too)
Previously, some of my changes made a @rake unit@ test fail, so I scaled back from modifying whitespace/indentation in multi-line strings.
History
Updated by Luke Kanies about 1 year ago
- Status changed from Unreviewed to Accepted
I can’t review the code right now, and I’m heading out for a short vacation, but if the code passes muster, I’m all about cleaning up whitespace issues.
Updated by James Turnbull about 1 year ago
Code looks good to me. I’m going to apply it.
Updated by James Turnbull about 1 year ago
- Category set to plumbing
- Status changed from Accepted to Closed
- Assignee set to James Turnbull
- Target version set to 0.25.0
Pushed in master.