Puppet » Facter

Not only are tests needed but I think it needs to be refactored a bit down near the bottom of virtual.rb where it keeps nesting if->else. That can be transformed into a loop somewhat easily. I have this done at home, just running into one little problem that is driving me insane. But, there are related bugs which I will be filing today.

I was just sitting here thinking and realized what I was doing wrong, so tonight from home I will submit a tiny re factor diff that also fixes the other two bugs I filed. IDK if you’ll want the code, but it was fun for me and maybe it will help you guys out somewhat.

Hey Paul, attached is the diff I was talking about. It refactors down bottom but also fixes detection in a couple cases. I’ll add a note to the other tickets.

Thanks – can you make sure your diff is against my working tree for this ticket

http://github.com/pnasrat/facter/tree/tickets/master/2292

Hey Paul, I’m not entirely convinced I did this diff properly. I followed your instructions, then did a git branch back to my working copy then diffed my virtual.rb against yours and this is what I got. If i’m ‘doin it wrong’ let me know. Thanks.

Joe your patch backs out some of my changes, I’ll try forward port but may split out into a seperate ticket to remove the duplication.

Initial refactor done, will continue to improve as add more facts to this area.