Bug #2197

Daemontools tests don't work

Added by Luke Kanies over 1 year ago. Updated about 1 year ago.

Status:Closed Start:04/24/2009
Priority:Normal Due date:
Assignee:Bryan Allen % Done:

0%
Category:testing
Target version:0.25.0
Affected version:0.24.7 Branch:
Keywords:
Votes: 0

Description

I get this:

1)
NoMethodError in 'Puppet::Type::Service::ProviderDaemontools when starting should call enable'
undefined method `[]' for nil:NilClass
/Users/luke/git/puppet/lib/puppet/provider/service/base.rb:132:in `ucommand'
/Users/luke/git/puppet/lib/puppet/provider/service/base.rb:81:in `start'
./spec/unit/provider/service/daemontools.rb:63:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'

2)
NoMethodError in 'Puppet::Type::Service::ProviderDaemontools when stopping should call disable'
undefined method `[]' for nil:NilClass
/Users/luke/git/puppet/lib/puppet/provider/service/base.rb:101:in `stop'
./spec/unit/provider/service/daemontools.rb:70:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'

3)
NoMethodError in 'Puppet::Type::Service::ProviderDaemontools when disabling should stop and then remove the symlink between daemon dir and service dir'
undefined method `[]' for nil:NilClass
/Users/luke/git/puppet/lib/puppet/provider/service/base.rb:101:in `stop'
/Users/luke/git/puppet/lib/puppet/provider/service/daemontools.rb:180:in `disable'
./spec/unit/provider/service/daemontools.rb:88:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'

4)
NoMethodError in 'Puppet::Type::Service::ProviderDaemontools when disabling should also call 'svc -dx /etc/service/myservice''
undefined method `[]' for nil:NilClass
/Users/luke/git/puppet/lib/puppet/provider/service/base.rb:101:in `stop'
/Users/luke/git/puppet/lib/puppet/provider/service/daemontools.rb:180:in `disable'
./spec/unit/provider/service/daemontools.rb:98:
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/Users/luke/git/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'

Finished in 0.070604 seconds

15 examples, 4 failures

If these aren’t fixed, the commits will need to get reverted.

Associated revisions

Revision 5680cd5029c8b3a2cf5a2a3b10df6acf7a9fc870
Added by Luke Kanies about 1 year ago

Fixing #2197 – daemontools tests now pass

This actually involved a bit of rewriting of the code, but the code’s simpler now, too.

Signed-off-by: Luke Kanies luke@madstop.com

History

#1
Updated by James Turnbull over 1 year ago

  • Assignee changed from James Turnbull to Bryan Allen

#2
Updated by Bryan Allen over 1 year ago

  • 3 changed from Unknown to Easy

#3
Updated by Bryan Allen over 1 year ago

Local time scheduled.

#4
Updated by James Turnbull over 1 year ago

These tests are still outstanding. Any progress on them? Thanks!

#5
Updated by James Turnbull over 1 year ago

Bump. Still need to fix tests. If they don’t get fixed I’ll have to revert the commit.

#6
Updated by Luke Kanies about 1 year ago

  • Status changed from Accepted to Ready for Testing
  • Assignee changed from Bryan Allen to James Turnbull

I’ve got fixes in the tickets/master/2197 branch in my repo, but they change behaviour a bit, so I would appreciate it if someone could test it.

#7
Updated by James Turnbull about 1 year ago

  • Assignee changed from James Turnbull to Bryan Allen

Can you test Bryan?

#8
Updated by James Turnbull about 1 year ago

  • Status changed from Ready for Testing to Closed

Pushed in commit:“5680cd5029c8b3a2cf5a2a3b10df6acf7a9fc870” in branch master.

Also available in: Atom PDF