Bug #2149

Client facts should be sent to server as request parameters

Added by Luke Kanies over 1 year ago. Updated over 1 year ago.

Status:Closed Start:04/09/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:plumbing
Target version:0.25.0
Affected version:0.24.7 Branch:
Keywords:
Votes: 0

Description

In order to support shared-nothing on the server, the client facts need to be sent as attributes to the Catalog.find call on the client, rather than in a separate request.

This should be straightforward, and should all take place in the Configurer class.

I don’t know whether it’s best to just serialize the Facts instance and pass that as an argument, or to set each of the facts as request parameters. Probably the former, so there’s no collision between the two.

Associated revisions

Revision b249f87a8c9a7e358e8d82d658247cd4be01a3d7
Added by Luke Kanies over 1 year ago

Fixing #2149 – Facts are passed as part of the catalog request

This removes the requirement of shared fact caching on the servers, since the server responding to the catalog request will receive the facts as part of the request.

The facts are serialized as a parameter to the request, rather than each being set as a separate request parameter.

This hard-codes yaml as the serialization format for the facts, because I couldn’t get marshal to work and it’s just not as big a deal for such a small amount of data.

Signed-off-by: Luke Kanies luke@madstop.com

History

#1
Updated by Luke Kanies over 1 year ago

  • Status changed from Accepted to Ready for Testing
  • Assignee changed from Luke Kanies to James Turnbull

Fixed in the tickets/master/2149 branch in my repo.

#2
Updated by Luke Kanies over 1 year ago

  • Status changed from Ready for Testing to Ready for Checkin

I’ve tested this as much as I think is reasonable, and I don’t see anyone else kicking it around, so….

#3
Updated by James Turnbull over 1 year ago

  • Status changed from Ready for Checkin to Code Insufficient
  • Assignee changed from James Turnbull to Luke Kanies

Can you rebase this one on current HEAD?

#4
Updated by Luke Kanies over 1 year ago

  • Status changed from Code Insufficient to Ready for Checkin
  • Assignee changed from Luke Kanies to James Turnbull

Done.

#5
Updated by James Turnbull over 1 year ago

  • Status changed from Ready for Checkin to Closed

Pushed in branch master.

Also available in: Atom PDF