Bug #2146

daemontools.rb does not need to unlink a service symlink to down a service

Added by Bryan Allen over 1 year ago. Updated 4 months ago.

Status:Closed Start:04/08/2009
Priority:Low Due date:
Assignee:- % Done:

0%
Category:service
Target version:0.25.0
Affected version:0.24.7 Branch:
Keywords:daemontools provider service
Votes: 0

Description

“disable” and “stop” are currently the same behavior. This is unnecessary. “svc -d” will down a service and not restart it until the system is rebooted or svscan is restarted (which should theoretically only happen on reboot or telinit q).

ensure => “stopped” should only do an svc -d on the service.

History

#1
Updated by Bryan Allen over 1 year ago

Fixed here: http://github.com/bda/puppet/tree/ticket/0.24.x/2146

#2
Updated by Bryan Allen over 1 year ago

commit 9f2b7e9c4ed76c0203ccb8ee8943a7f964cdef73 commit c5aa27bfee24c1e2e0f2186a5cbc4854f74fafec commit b4f32dd0bc58b9b426f92ea2a1e7d588ea9f4a7b commit ed2429e87dfd7a613260e88c1a4ac812a81b8669 commit 9dea54455d4a352dc14c577035bb0aded3a0b0d6 commit 77f9e316d0e09863c737754028dd9c7bf7116856

#3
Updated by Luke Kanies over 1 year ago

  • Status changed from Unreviewed to Accepted

Can you email your code to the -dev list for review?

#4
Updated by Bryan Allen over 1 year ago

Sent.

#5
Updated by James Turnbull over 1 year ago

  • Status changed from Accepted to Closed
  • Target version set to 0.25.0

Pushed in commit:“f1f0a57e4cafc5a9a4378f367022f7cc591033d7” in branch master.

Also available in: Atom PDF