Bug #2124

ssh_authorized_key always changes target if target is not defined

Added by Tony . over 1 year ago. Updated over 1 year ago.

Status:Closed Start:04/01/2009
Priority:Normal Due date:
Assignee:Francois Deppierraz % Done:

0%

Category:ssh
Target version:0.25.0
Affected version:0.24.8 Branch:
Keywords:
Votes: 0

Description

This one looks to be a continuation of http://projects.reductivelabs.com/issues/2004 when you don’t specify a target you get target changed output on every run. This was not the case in 0.24.7

target not defined

ssh_authorized_key { "test@test":
   ensure => present,
   key => 'AAAAAA',
   type => "ssh-rsa",
   user => "test",
}

In 0.24.8 produces

notice: //Node[tjtest.obuops.bskyb.com]/base/users::obuops/Ssh_authorized_key[test@test]/target: target changed '/home/test/.ssh/authorized_keys' to '/home/test/.ssh/authorized_keys'
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /home/test/.ssh/authorized_keys(765bc34f409feb56228f6fc93eaf108b)

In 0.24.7 produces no output

target defined

ssh_authorized_key { "test@test":
   ensure => present,
   target => '/home/test/.ssh/authorised_keys',
   key => 'AAAAAA',
   type => 'ssh-rsa',
   user => 'test',
}

In 0.24.7 & 0.24.8 produces no output

History

Updated by Francois Deppierraz over 1 year ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Francois Deppierraz

Updated by Francois Deppierraz over 1 year ago

  • Category set to ssh

Updated by Francois Deppierraz over 1 year ago

  • Status changed from Accepted to Ready for Testing

A patch fixing this issue has been submitted on puppet-dev, it works on my environment but further testing would be greatly appreciated.

http://github.com/ctrlaltdel/puppet/commit/f63841adef78a9dcf71f9889bb6e9089bf7d6c92

The branch is available on: http://github.com/ctrlaltdel/puppet/commits/tickets/master/2124

Updated by Francois Deppierraz over 1 year ago

  • Status changed from Ready for Testing to Ready for Checkin

It was successfully tested on two differents sites, one Debian,Ubuntu and the other one Redhat Entreprise.

Updated by Luke Kanies over 1 year ago

  • Target version set to 0.25.0

Updated by James Turnbull over 1 year ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“172422fc0422e2646c4cc3afb7955876651cbf3e” in branch master.

Also available in: Atom PDF