Bug #2111

Puppet goes into an infinite recursion with a host and resources { purge => true }

Added by Eric Gerlach over 1 year ago. Updated over 1 year ago.

Status:Closed Start:03/26/2009
Priority:Normal Due date:
Assigned to:James Turnbull % Done:

0%
Category:plumbing
Target version:0.25.0
Affected version:0.25.0 Branch:
Keywords:
Votes: 0

Description

Here’s the test case:

$ puppet --trace test.pp

--- test.pp
node default {
    host { "test":
        ip => "1.2.3.4",
        target => "/path/to/a/nondefault/hosts"
    }
}

resources { host:
    purge => true
}
---

I have no idea what’s going on here… but methinks it’s a bug…

Associated revisions

Revision 88ff9c6500e76fdda02e60262dd1571577c0b92b
Added by Luke Kanies over 1 year ago

Fixing #2111 – SimpleGraph only creates valid adjacencies

The way this class was testing edges was causing them to appear adjacencies to appear magically, because it was only testing that a hash had a key, not that the value had any edges.

This fixes the infinite recursion mentioned in #2111.

Signed-off-by: Luke Kanies luke@madstop.com

History

Updated by Eric Gerlach over 1 year ago

  • Subject changed from Puppet goes into an infinite recursion with a host with a non-default target and resources { purge => true } to Puppet goes into an infinite recursion with a host and resources { purge => true }

Did another test. The non-default target isn’t required. Remove the “target => ” line and the same thing occurs. New test case:

—– test.pp node default {

host { "test":
    ip => "1.2.3.4"
}

}

resources { host:

purge => true

}

Updated by Luke Kanies over 1 year ago

  • Category set to plumbing
  • Status changed from Unreviewed to Accepted
  • Assigned to set to Luke Kanies
  • Target version set to 0.25.0

Updated by Luke Kanies over 1 year ago

  • Status changed from Accepted to Ready for Checkin
  • Assigned to changed from Luke Kanies to James Turnbull

Fixed in the tickets/master/2111 branch in my repo.

This was a doozie – probably the hardest bug I’ve tracked down in a year.

Updated by Luke Kanies over 1 year ago

  • Status changed from Ready for Checkin to Closed

Merged as commit:“88ff9c6500e76fdda02e60262dd1571577c0b92b”.

Also available in: Atom PDF