Puppet » Facter

Luke?

Fixing the markup.

I just tested this, and it works fine for me:

luke@phage $ ls -al $(puppet --configprint libdir)/facter
total 4
drwxr-xr-x 3 luke admin 102 2009-03-02 21:58 .
drwxr-xr-x 4 luke admin 136 2009-01-29 16:19 ..
-rw-r--r-- 1 luke admin  85 2009-03-02 21:58 testfact.rb
luke@phage $ cat $(puppet --configprint libdir)/facter/testfact.rb
require 'facter'

Facter.add("testfact") do
    setcode do
        "yep"
    end
end
luke@phage $ facter | grep testfact
luke@phage $ facter --puppet | grep testfact
testfact => yep
luke@phage $ 

This 1.5.4 and Puppet 0.24.x HEAD.

Please reopen if you’re really convinced it’s a Facter problem and not a problem in your environment.

I’m having the same problem here:

[root@xen0-devel ~]# rpm -q facter puppet ruby facter-1.5.4-1.el5 puppet-0.24.8-1.el5.1 ruby-1.8.5-5.el5_2.6 [root@xen0-devel ~]# ls -al $(puppet —configprint libdir)/facter total 24 drwxr-xr-x 2 root root 4096 Apr 10 10:07 . drwxr-xr-x 3 root root 4096 Nov 29 20:18 .. -rw-r—r— 1 root root 87 Apr 10 10:01 testfact.rb [root@xen0-devel ~]# cat $(puppet —configprint libdir)/facter/testfact.rb require ‘facter’

Facter.add(“testfact”) do

setcode do
    "yep" 
end

end

[root@xen0-devel ~]# facter —puppet | grep testfact [root@xen0-devel ~]#

This is a CentOS 5 host with latest puppet and facter from epel repo. How can I debug the problem? If it’s a bug in the RPM packages I will report it to EPEL

kuko wrote:

This is a CentOS 5 host with latest puppet and facter from epel repo. How can I debug the problem? If it’s a bug in the RPM packages I will report it to EPEL

Edit the Facter executable to print $LOAD_PATH after the ‘require “puppet”’ is called. If your Puppet libdir isn’t in the ruby loadpath, then that’s the problem. If it is, then, well, something even weirder is going on. But that’s what loading Puppet does for you — adds its libdir to your ruby Load path.

Hmm, I just realized – are you overriding the value of ‘libdir’ or some parent dir in your Puppet configuration? If so, that’s probably the problem; Facter doesn’t tell Puppet to load its configuration, and it would need so for that to work. Try adding ‘Puppet.parse_config’ after the ‘require “puppet”’‘ line in Facter, see if that fixes it.

It’s also worth just making sure your fact works:

ruby -rfacter .../path/to/fact.rb

And try loading the Puppet libs yourself:

ruby -rpuppet /path/to/facter | grep testfact

adding ‘Puppet.parse_config’ after the ‘require “puppet”’‘ line works perfectly, however, I’m not modifying libdir, but some of the others:

[root@foo1-vm:~]# cat /etc/puppet/puppet.conf | grep -v "#"
[main]
logdir = /var/log/puppet
vardir = /var/lib/puppet
ssldir = /var/lib/puppet/ssl
rundir = /var/run/puppet
pluginsync = true
factpath = /var/lib/puppet/lib/facter


[puppetmasterd]
templatedir = /var/lib/puppet/templates

The difference between the libdirs are:

with Puppet.parse_config

["/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/i18n-0.0.1", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/tzinfo-0.3.12", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/memcache-client-1.5.1", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/xml-simple-1.0.11", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/builder-2.1.2", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/bin", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib", "/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/bin", "/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib", "/usr/local/lib/site_ruby/1.8", "/usr/local/lib/site_ruby/1.8/x86_64-linux", "/usr/local/lib/site_ruby", "/usr/lib/ruby/vendor_ruby/1.8", "/usr/lib/ruby/vendor_ruby/1.8/x86_64-linux", "/usr/lib/ruby/vendor_ruby", "/usr/lib/ruby/1.8", "/usr/lib/ruby/1.8/x86_64-linux", ".", "/var/puppet/lib"]

without

["/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/i18n-0.0.1", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/tzinfo-0.3.12", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/memcache-client-1.5.1", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/xml-simple-1.0.11", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib/active_support/vendor/builder-2.1.2", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/bin", "/usr/lib/ruby/gems/1.8/gems/activesupport-2.2.2/lib", "/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/bin", "/usr/lib/ruby/gems/1.8/gems/activerecord-2.2.2/lib", "/usr/local/lib/site_ruby/1.8", "/usr/local/lib/site_ruby/1.8/x86_64-linux", "/usr/local/lib/site_ruby", "/usr/lib/ruby/vendor_ruby/1.8", "/usr/lib/ruby/vendor_ruby/1.8/x86_64-linux", "/usr/lib/ruby/vendor_ruby", "/usr/lib/ruby/1.8", "/usr/lib/ruby/1.8/x86_64-linux", ".", "/var/puppet/lib"]

which are the same!

(this is on debian etch, with Ruby 1.8.7, puppet 0.24.8, and facter 1.5.4)

The libdir is usually in the vardir, so changing the vardir changes the libdir.

This is clearly the problem, and simply parsing the config file should suffice (although it’s not entirely trivial, since the method profile changes in master.

Fixed in the tickets/master/1918 branch in my repo.

Can you rebase on 1.5.x please. Also what is – commit:“33fe2b63f363b1f1f823e9938de93f5aa94e8efd”? I don’t see a ticket for it???

Rebased.

And that commit didn’t seem like it deserved a ticket. It’s pretty small, just removes trailing colons from interface names.

Until it caused a merge conflict… :)

Pushed in commit:“516402c77f9c7d751c627db36885e12aaff62bf9” in branch 1.5.x