Bug #8872

Silent puppetmaster crash with invalid fileserver.conf

Added by Simon Lodal 10 months ago. Updated 10 months ago.

Status:Accepted Start date:08/09/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:server
Target version:2.7.x
Affected Puppet version: Branch:
Keywords:crash
Votes: 1

Description

I accidentally copied auth.conf over fileserver.conf. The result is that puppetmaster crashes during startup, and worse, does so without a word. The daemon just disappears, silently. No warnings, errors or any other kind of clue in logs or on command line.

Quite annoying as it took me a while to figure out the cause. I would say the config parser could use some more robustness.

puppetmaster-2.7.1 (debian testing).

History

#1
Updated by Nan Liu 10 months ago

  • Status changed from Unreviewed to Needs Decision

If you do this puppet master crashes immediately and indicate an issue with fileserver.rb.

puppet master -d --no-daemonize

notice: Starting Puppet master version 2.6.4 (Puppet Enterprise 1.0)
/opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:270:in `readconfig': undefined method `name' for nil:NilClass (NoMethodError)
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:256:in `each'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:256:in `readconfig'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:253:in `open'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:253:in `readconfig'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:115:in `initialize'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:135:in `new'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:135:in `xmlrpc_servlet'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:131:in `collect'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:131:in `xmlrpc_servlet'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:126:in `setup_handlers'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:36:in `listen'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/server.rb:127:in `listen'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/network/server.rb:142:in `start'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/daemon.rb:124:in `start'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/application/master.rb:114:in `main'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/application/master.rb:46:in `run_command'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/application.rb:287:in `run'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/application.rb:393:in `exit_on_fail'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/application.rb:287:in `run'
    from /opt/puppet/lib/ruby/site_ruby/1.8/puppet/util/command_line.rb:55:in `execute'
    from /usr/local/bin/puppet:4

I think there’s sufficient info, but I’ll leave this to product manager to determine whether to accept or reject.

#2
Updated by Daniel Pittman 10 months ago

  • Status changed from Needs Decision to Accepted

#3
Updated by Daniel Pittman 10 months ago

We have enough evidence to call this a real bug, so may as well file it for future fixin'

Also available in: Atom PDF