Feature #8701

Make --waitforcert a parameter in puppet.conf

Added by Oliver Beattie 10 months ago. Updated 14 days ago.

Status:Merged - Pending Release Start date:07/29/2011
Priority:Normal Due date:09/05/2011
Assignee:Kelsey Hightower % Done:

100%
Category:newfeature
Target version:3.0.0 Estimated time:2.00 hours
Affected Puppet version: Branch:https://github.com/kelseyhightower/puppet/tree/ticket/master/8701_waitforcert_param_configurable_for_puppet_agent
Keywords:
Votes: 1

Description

It would be useful to be able to configure the default value of —waitforcert through a configuration parameter in [agent], rather than being force to specify it on the command line.

For those of us using automatically provisioned environments (EC2 autoscaling), where we’re not manually intervening in the setup of our nodes, 120 seconds can be a long time to have to wait for a certificate to be signed (autosign is off, but a separate script on the master takes care of signing requests).

History

#1
Updated by James Turnbull 10 months ago

  • Status changed from Unreviewed to Needs Decision
  • Assignee set to Nigel Kersten

#2
Updated by Nigel Kersten 10 months ago

  • Status changed from Needs Decision to Accepted
  • Assignee deleted (Nigel Kersten)
  • Target version set to 3.x

#3
Updated by K Hightower 9 months ago

  • Due date set to 09/05/2011
  • Assignee set to K Hightower
  • Estimated time set to 2.00

#4
Updated by K Hightower 9 months ago

Right now my plan is to set the default value for waitforcert as follows:

[agent]
waitforcert = 120

This matches the default value of waitforcert when puppet agent is running in daemon mode. Any objections?

#5
Updated by K Hightower 9 months ago

  • % Done changed from 0 to 100
  • Branch set to https://github.com/khightower/puppet/commits/feature/master/8701

#6
Updated by K Hightower 9 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

#7
Updated by Kelsey Hightower 4 months ago

  • Assignee changed from K Hightower to Kelsey Hightower
  • Branch changed from https://github.com/khightower/puppet/commits/feature/master/8701 to https://github.com/kelseyhightower/puppet/tree/ticket/master/8701_waitforcert_param_configurable_for_puppet_agent

Updating to a branch I have access to, and the patch has been rebased on current master.

#8
Updated by Kelsey Hightower 4 months ago

Pending Review

This patch has been rebased on master, and two spec titles have been updated. The new pull request can be found here: Pull 416

#9
Updated by Daniel Pittman 4 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Merged, thanks. That is totally something we should make available from the config file, not just the command line.

#10
Updated by Daniel Pittman 14 days ago

  • Target version changed from 3.x to 3.0.0

Also available in: Atom PDF