Bug #8201

Filebucket API diffs should respect the diff and diff_args settings

Added by Nick Fagerlund 11 months ago. Updated 6 months ago.

Status:Accepted Start date:07/01/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:API
Target version:2.7.x
Affected Puppet version: Branch:
Keywords:REST, filebucket, diff
Votes: 0

Description

Diffs in the Dashboard end up looking like this:

4d3
< ****demonstration file content difference****

(How do you even roll 4d3? Do they look like little Brazil-nuts?)

Anyway, it’s just rendering whatever it got from the master’s REST API, and for some reason the API isn’t respecting the -u flag in the diff_args setting.

By default, the diff API should render according to Puppet’s global settings, and it’d be nice to have it overrideable via an expanded API call syntax as well (to support easier machine-parsing of diff formats when we don’t need to show them to hu-mans).

History

#1
Updated by Jacob Helwig 11 months ago

  • Status changed from Unreviewed to Accepted
  • Target version set to 2.7.x

#2
Updated by Nigel Kersten 6 months ago

Adding Jeff and Dan H as watchers as they thought this was already possible.

We don’t respect the diff_args setting unfortunately.

Also available in: Atom PDF