Bug #795

--config is not happy with relative pathnames

Added by Matt Palmer over 4 years ago. Updated over 4 years ago.

Status:Closed Start date:
Priority:Normal Due date:
Assignee:Luke Kanies % Done:

0%
Category:-
Target version:0.24.0
Affected Puppet version:0.25.4 Branch:
Keywords:
Votes: 0

Description

If you pass your puppetmaster a 

—config
option with a relative path, you will get regular complaints along the lines of:

err: Could not create ../puppet.conf: Parameter path failed: File paths must be fully qualified
err: Parameter path failed: File paths must be fully qualified

The cause is actually the manifest that the Puppetmaster is trying to execute internally, in that it has a resource for the config file, and it’s that that has the philosophical objection to relative paths.

Either 

—config
should explicitly disallow relative paths (bad idea), or the filename should be canonicalised through 
File.expand_path
. I tried looking for a way to do this, but got lost in the maze of twisty passages and died of thirst.

History

#1
Updated by Luke Kanies over 4 years ago

  • Status changed from 1 to Closed
  • 7 set to fixed

Fixed in commit:7abc78ad25979c62b585127a8f2a32c55e96819f.

And it was a trivial fix, might I add. One line in one easy-to-find method — find the to_transportable method on the CFile class, which models files, and have it prepend Dir.getwd to the path when necessary.

Please, hold off on the snotty comments.

Also available in: Atom PDF