Feature #7896

Does not support setting the image size.

Added by Teyo Tyree 12 months ago. Updated 10 months ago.

Status:Closed Start date:06/13/2011
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:cloudpack Spent time: -
Target version:0.6.0
Keywords: Roadmapped:No
Branch:
Votes: 0

Description

This limits Cloud-Pack to being able to provision only t1.micro sized ec2 instances.

History

Updated by Teyo Tyree 12 months ago

  • Tracker changed from Bug to Feature

Updated by Teyo Tyree 12 months ago

Here is my feature branch.

https://github.com/teyo/puppet-cloudpack/tree/feature%2Fmaster%2F7896-add-support-for-image-size

Sent a pull request.

Updated by Jeff McCune 11 months ago

  • Status changed from Unreviewed to Merged - Pending Release
  • Roadmapped set to No

Updated by Jeff McCune 11 months ago

Merged into master.

I’m a little worried that the addition of the required option breaks other spec tests, and I jumped the gun merging this into master, but I’ll go through and sort them out.

Updated by Teyo Tyree 11 months ago

I have code in a branch that fixes the tests and addresses the issues that Randall brought up. I’ll review that and send a pull request ASAP.

-teyo

Updated by Jeff McCune 11 months ago

Teyo,

I’ve already fixed the spec tests.

What issues did Randall bring up? I don’t see any mention of them here in the ticket and I didn’t see anything on the pull request.

I’m about to merge the spec test fixes into the master branch. Please rebase whatever other issues Randall brought up against master.

-Jeff

Updated by Jeff McCune 11 months ago

Fixed spec tests merged into master

commit 64a29eb2e7ee38a25445d408fb940175295e4716
Merge: 7e49217 aad6758
Author: Jeff McCune 
Date:   Wed Jun 29 18:59:32 2011 -0700

    Merge branch 'ticket/master/7896_fix_rspec_tests'
    
    * ticket/master/7896_fix_rspec_tests:
      (#7896) Fix spec tests broken by new required option

commit aad67589be72b7ff2f4ef021d260895327d3763e
Author: Jeff McCune 
Date:   Wed Jun 29 18:54:31 2011 -0700

    (#7896) Fix spec tests broken by new required option
    
    The patch added in #7896 broke some of the existing rspec tests by
    introducing a new required option.
    
    This change adds the required option to the existing spec tests.  All of
    them now pass.

Updated by Jeff McCune 11 months ago

  • Target version set to 0.6.0

Updated by Nigel Kersten 10 months ago

  • Category set to cloudpack

Updated by Jeff McCune 10 months ago

  • Status changed from Merged - Pending Release to Closed

Also available in: Atom PDF