Feature #636

Trailing commas should not throw syntax error when used with functions

Added by Benjamin Kite about 5 years ago. Updated about 2 years ago.

Status:Closed Start date:
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:language
Target version:0.24.6
Affected Puppet version:0.24.4 Branch:
Keywords:
Votes: 0

Description

For example, the trailing comma after bob below throws an error:

class team_adm_users {
    realize(
        Adm_user[[alice]],
        Adm_user[[bob]],
    )
}

History

#1
Updated by Luke Kanies almost 5 years ago

I’ve tried to fix this a couple of times and I can’t seem to do it in a way that doesn’t result in lots of shift/reduce conflicts.

#2
Updated by Redmine Admin almost 4 years ago

  • Status changed from 1 to Accepted

#3
Updated by Brice Figureau over 3 years ago

  • Affected Puppet version set to 0.24.4

ajax wrote:

For example, the trailing comma after bob below throws an error:

[…]

I have fixed this in the tickets/0.24.x/636 branch on my github repository: http://github.com/masterzen/puppet/tree/tickets%2F0.24.x%2F636

Note: it might conflict with the fix in #936 as both are touching the autogenerated parser.rb and tests. If rebasing is needed please let me know.

#4
Updated by Brice Figureau over 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee changed from Puppet Community to James Turnbull
  • Target version changed from 0.25.0 to 0.24.6

#5
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:e6f99f92ec5bfba973a3f13c629a8ce263a0da7d in branch 0.24.x

Also available in: Atom PDF