Bug #5984

syntax error in import manifest only reported once

Added by Johan Huysmans over 1 year ago. Updated 4 months ago.

Status:Accepted Start date:01/24/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:agent
Target version:2.7.x
Affected Puppet version:2.6.1 Branch:
Keywords:
Votes: 3

Description

In my setup the site.pp contains a set of import statements in import classes and variables from other files, while the actual node definition is situation in the site.pp file itself.

When a syntax error is made in the site.pp this is reported on every puppet run until the problem is fixed. When a syntax error is made in one of the imported files, this error is reported the first time puppet runs. The second time it will won’t give an error and just says “notice: Finished catalog run…”

History

#1
Updated by Johan Huysmans over 1 year ago

The problem also exists using following version: puppet-2.6.2-0.3.el5 puppet-server-2.6.2-0.3.el5

#2
Updated by Dan Bode over 1 year ago

  • Status changed from Unreviewed to Accepted
  • Affected Puppet version changed from 2.6.1 to 2.6.5rc1

verified against 2.6.next

site.pp

import 'node.pp'
node default {
  notify{'default':}
}

node.pp

notify{'foo':}
dfd

launch puppetmaster

# puppet master --no-daemonize  --verbose
/usr/local/dev/puppet//lib/puppet/network/rights.rb:91: warning: parenthesize argument(s) for future version
notice: Starting Puppet master version 2.6.4

# puppet agent --test
info: Loading facts in certname
info: Loading facts in certname
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not parse for environment production: Syntax error at end of file at /etc/puppet/manifests/node.pp:3 on node puppetclient
warning: Not using cache on failed catalog
err: Could not retrieve catalog; skipping run
[root@mypuppetmaster node]# puppet agent --test
info: Loading facts in certname
info: Loading facts in certname
info: Caching catalog for puppetclient
info: Applying configuration version '1296757727'
notice: Finished catalog run in 0.02 seconds

#3
Updated by Nigel Kersten over 1 year ago

  • Target version set to 2.6.x
  • Affected Puppet version changed from 2.6.5rc1 to 2.6.1

#4
Updated by Johan Huysmans about 1 year ago

What is the status of this issue?

If find the issue very annoying as we don’t have any visibility when someone makes an syntax error in one of the include pp files.

#5
Updated by Carl Caum 11 months ago

I can’t reproduce this in 2.7.1. Could someone please verify?

#6
Updated by James Turnbull 11 months ago

I have a feeling this is fixed – a similar issues was fixed in 2.7.0 I think.

#7
Updated by Johan Huysmans 9 months ago

Is there a possibility it will be backported to the 2.6.x branch?

#8
Updated by Johan Huysmans 9 months ago

Is there a way we can work around this issue?

I’ve noticed that when the puppetmaster is restarted the error is shown again. Can we trigger the same effect without restarting the puppetmaster? Like remove a certain file?

#9
Updated by Johan Huysmans 8 months ago

I noticed myself that when the file is touched puppet will re-read it and the error will be shown again (1 time)

#10
Updated by Michael Stahnke 4 months ago

  • Target version changed from 2.6.x to 2.7.x

2.6.x is closed. Moving to 2.7.x

Also available in: Atom PDF