Puppet

Just to clarify, I linked the two autorequire tickets due to implicit conceptual collision between the issues discussed on the respective threads on puppet-dev; specifically, those tickets propose expanding / extending the autorequire functionality while Luke’s refactor/master/3691-no_relationship_graph branch, which he suggested as an alternate resolution on the thread for this ticket removes autorequire functionality and it’s not immediately clear (to me at least) how it could be restored in that model.

I think eliminating the second graph as Luke’s branch does is the right idea, and I think representing containment with bracket node as Tervor, Jesse and other have advocated is better than adding edge types. But I’m not yet seeing how either idea can work in actual code. Just adding bracket nodes as an added complication in splice! looks like the easiest, though significantly less efficient. In short, I’m finding myself in agreement with pretty much everyone on the details and with almost no one on the big picture.

To update: Jesse & I have a working sketch of the bracket solution which keeps the “two graphs” structure for now. It’s turning out to be a needed step for #6911 and will probably be folded in with that.

The branch on #6911 now contains a sketch of the fix for this, with one known bug and a small amount of cleanup left to do.

This issue was assigned to a former Puppet Labs employee. Adding back to the pool of unreviewed issues.