Bug #4996

FreeBSD package provider rewrite to use port origin when querying installed packages

Added by Russell Jackson over 1 year ago. Updated 2 months ago.

Status:Code Insufficient Start date:10/14/2010
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:FreeBSD
Target version:-
Affected Puppet version: Branch:https://github.com/xraj/puppet/commits/freebsd%2Fpackage
Keywords:
Votes: 5

Description

This fixes the problem where the port name specified in the package resource name (used by pkg_add -r) doesn’t match what is recorded as the package name by pkg_info. Puppet therefore thinks the package isn’t installed and tries to install it on every run. By consistently using the port origin everywhere when querying for installed packages, we avoid this problem.

Related issues

related to Puppet - Bug #6096: FreeBSD package removal Duplicate 01/31/2011
related to Puppet - Feature #5951: Freebsd Package Manager rewrite (as fbsd) Needs Decision 01/20/2011
duplicated by Puppet - Bug #4760: remove freebsd ports provider Duplicate 09/13/2010

History

#1
Updated by Russell Jackson over 1 year ago

Should I attach a patch or is the git branch URL sufficient?

#2
Updated by Markus Roberts over 1 year ago

  • Status changed from Unreviewed to Investigating

I’ll post this to puppet-dev for comment…

#3
Updated by Russell Jackson about 1 year ago

  • Branch changed from http://github.com/pthreadunixman/puppet/commits/freebsd/2.6.x/package_origin to https://github.com/xraj/puppet/commits/freebsd%2Fpackage

#4
Updated by Russell Jackson about 1 year ago

I’ve rake mail_patches the current feature branch for review.

#5
Updated by Nigel Kersten about 1 year ago

Thanks Russell.

#6
Updated by Nigel Kersten about 1 year ago

  • Status changed from Investigating to Accepted

#7
Updated by Jacob Helwig 12 months ago

I’ve left a couple of comments on the patch series on the mailing list.

#8
Updated by Tim Bishop 6 months ago

  • Category set to FreeBSD

Hi. Just wondering what the status is of this one? Would be nice to see it merged.

#9
Updated by Nigel Kersten 6 months ago

  • Assignee set to Jacob Helwig

#10
Updated by James Turnbull 6 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

#11
Updated by Jacob Helwig 6 months ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

This was reviewed on the mailing list, and needs work before it can be merged.

#12
Updated by Jacob Helwig 5 months ago

  • Assignee deleted (Jacob Helwig)

Also available in: Atom PDF