Refactor #4883

Encapsulate RRDtool librrd4 logic so that it's cleaner and easier to test

Added by Matt Robinson over 1 year ago. Updated over 1 year ago.

Status:Accepted Start date:09/29/2010
Priority:Low Due date:
Assignee:- % Done:

0%

Category:testing
Target version:2.7.x
Affected Puppet version:2.6.1 Branch:
Keywords:
Votes: 0

Description

Lots of rrd reporting is poorly tested. RRDtool is no longer maintained so ticket #4726 included support for librrd4. To do this there’s a lot of if/else statements that check which rrd library you’re using which makes it harder to write good tests. RRD logic should be wrapped in a class so that we can easily stub the methods to write better tests and make switching out rrd libraries easier in the future.


Related issues

related to Puppet - Feature #4726: Support RRD's built-in ruby bindings instead of the old R... Closed 09/04/2010
related to Puppet - Bug #4783: rrd reporting not generating rrd files Closed 09/15/2010

History

Updated by James Turnbull over 1 year ago

  • Target version changed from 52 to 2.7.x

Also available in: Atom PDF