Bug #4879

NodesController should use common method to fetch node

Added by Igal Koshevoy over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:09/29/2010
Priority:Normal Due date:
Assignee:Igal Koshevoy % Done:

0%
Category:-
Target version:1.0.4
Keywords: Affected URL:
Branch:http://github.com/igal/puppet-dashboard/commits/bug/next/4879-commonize_nodes_controller_resource_fetch_method Affected Dashboard version:
Votes: 0

Description

The #show and #reports methods use separate fetching code.

History

#1
Updated by Igal Koshevoy over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Igal Koshevoy to Jacob Helwig
  • Branch set to http://github.com/igal/puppet-dashboard/commits/bug/next/4879-commonize_nodes_controller_resource_fetch_method

Jacob: Please review…

(#4879) Use common method to fetch node in NodesController.

The #show and #reports methods used to fetch the node in different ways.
These now use common code and also include the last_report, which is
always used.

#2
Updated by Igal Koshevoy over 1 year ago

  • Subject changed from NodesController should use common method to fetch node and include its last_report to NodesController should use common method to fetch node

Update: removed requirement to include #last_report because it wasn’t used by #reports. Pushed amended branch.

#3
Updated by Igal Koshevoy over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed
  • Assignee changed from Jacob Helwig to Igal Koshevoy

Jacob reviewed this on the puppet-dev mailing list. Merged into next.

Also available in: Atom PDF