Bug #4743

The audit metaparameter does not handle the value 'all' properly.

Added by Cody Herriges over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:09/08/2010
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:metaparameters
Target version:2.6.2
Affected Puppet version: Branch:http://github.com/jhelwig/puppet/tree/bug/2.6.x/4743-audit-metaparam
Keywords:
Votes: 0

Description

The special ‘all’ value that can be assigned to the meta parameter audit is not getting passed to lib/puppet/type.rb the way it expects. Puppet is handing the value off as a string and type.rb is expecting a symbol. This doesn’t match the conditionals used in the newmetaparam block for audit and so never actually iterates through the type/provider to collect all the possible parameters that can be audited. Instead it just exits on fail with ‘Cannot audit all: no a valid attribute.’

I fix this at http://github.com/ody/puppet/tree/issue/4743 by simply changing the symbols to strings in the newmetaparam block for audit.

issue_4743.patch (732 Bytes) Cody Herriges, 09/09/2010 12:10 am

History

#1
Updated by Cody Herriges over 1 year ago

  • File issue_4743.patch added
  • Subject changed from The audit metaparameter does not handle the value to all properly. to The audit metaparameter does not handle the value 'all' properly.

#2
Updated by James Turnbull over 1 year ago

  • Category set to metaparameters
  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Target version set to 2.6.2

#3
Updated by Jacob Helwig over 1 year ago

  • Affected Puppet version deleted (2.6.1rc4)
  • Branch set to http://github.com/jhelwig/puppet/tree/bug%2F2.6.x%2F4743-audit-metaparam

The proposed patch breaks the existing test. I’ve sent an alternate patch to the mailing list.

#4
Updated by Jacob Helwig over 1 year ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

Reviewed by Paul on the mailing list.

#5
Updated by Markus Roberts over 1 year ago

  • Branch changed from http://github.com/jhelwig/puppet/tree/bug%2F2.6.x%2F4743-audit-metaparam to http://github.com/jhelwig/puppet/tree/bug/2.6.x/4743-audit-metaparam

#6
Updated by Markus Roberts over 1 year ago

  • Status changed from Ready For Checkin to Closed

Pushed to 2.6.x as commit:9e17c25117f9f3012f64d3d39053750159632782

Also available in: Atom PDF