Feature #4726

Support RRD's built-in ruby bindings instead of the old RRDTool ruby library

Added by Davor Ocelic over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:09/04/2010
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

100%
Category:reports
Target version:2.6.3
Affected Puppet version: Branch:https://github.com/mmrobins/puppet/tree/ticket/2.6.x/4726
Keywords:
Votes: 0

Description

RRDtool support in Puppet is old, and installing the old version of RRDtool Ruby bindings is almost mission impossible, since it is incompatible with the new librrd4 (both during compile-time and in runtime).

Instead of insisting on trying to get the old RRD code working, I’ve updated Puppet rrd metrics code to work with the now-standard librrd4.

Patches will follow for both 0.26 and 0.25.

puppet-rrdtool-interface.patch (2.7 kB) Davor Ocelic, 09/04/2010 03:39 pm

Related issues

related to Puppet - Refactor #4883: Encapsulate RRDtool librrd4 logic so that it's cleaner an... Accepted 09/29/2010

History

#1
Updated by Davor Ocelic over 1 year ago

The attached patch works for both current Git master and 0.25.x.

I’ve also sent it using rake mail_patches.

#2
Updated by James Turnbull over 1 year ago

  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Target version set to 2.6.2

#3
Updated by Jesse Wolfe over 1 year ago

This works fine, once #4783 is also applied.

#4
Updated by Jesse Wolfe over 1 year ago

  • Tracker changed from Refactor to Feature
  • Subject changed from Update puppet rrdtool metric code to Support RRD's built-in ruby bindings instead of the old RRDTool ruby library

#5
Updated by Jesse Wolfe over 1 year ago

  • Branch set to http://github.com/jes5199/puppet/tree/ticket/2.6.x/4726

Somehow Davor’s patch never hit the mailing list. I’ve re-submitted it with the addition that I’ve added conditionals so it can still call the old rrdtool library if a modern rrd is not installed.

#6
Updated by Markus Roberts over 1 year ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

#7
Updated by Markus Roberts over 1 year ago

  • Status changed from Ready For Checkin to Closed

Pushed to 2.6.x as commit:d057b90bba4ffe7174e9af789835d5528e8a200d

#8
Updated by Matt Robinson over 1 year ago

  • Status changed from Closed to Re-opened
  • Assignee set to Markus Roberts
  • Target version changed from 2.6.2 to 2.6.3

A bug was found in the code that caused RRD not to run if the old RRD library was installed. Here’s a branch with a patch. https://github.com/mmrobins/puppet/tree/ticket%2F2.6.x%2F4726. Note this branch includes a patch that Jesse got into next and master to fix some RRD issues. This patch should also get into 2.6.x so I’m appending it to the end of my branch for fixing the legacy RRD.

#9
Updated by Matt Robinson over 1 year ago

  • Status changed from Re-opened to Ready For Checkin
  • Branch changed from http://github.com/jes5199/puppet/tree/ticket/2.6.x/4726 to https://github.com/mmrobins/puppet/tree/ticket/2.6.x/4726

#10
Updated by Markus Roberts over 1 year ago

  • Status changed from Ready For Checkin to Closed

This really should have been a new ticket with a caused-by pointer back to this one rather than a re-open, since it’s a different issue with a different fix. But people in Phoenix want ice water. Added to 2.6.x as

commit:178c2a628256d22b6bec39ee6f9022b38c9aa4f4 Fix test failures that fixing #4726 exposed. commit:74b6c09e3b074e0ffc8679dcf31b5fa900020e39 (#4726) Fix RRD legacy support

Also available in: Atom PDF