Bug #4670

Puppet::Network::HTTP::WEBrick#listening? not reentrant

Added by Rein Henrichs over 1 year ago. Updated about 1 year ago.

Status:In Topic Branch Pending Review Start date:08/31/2010
Priority:Normal Due date:
Assignee:Nigel Kersten % Done:

0%
Category:-
Target version:2.7.x
Affected Puppet version: Branch:https://github.com/reinh/puppet/tree/ticket/master/4670
Keywords:
Votes: 0

Description

Puppet::Network::HTTP::WEBrick#listening? is wrapped in a Mutex#synchronize block. Not only is this unnecessary, it will cause bugs if listening? is called while the same mutex is locked, for instance inside listen or unlisten. This is because Mutex#synchronize is not reentrant.

History

#1
Updated by Rein Henrichs over 1 year ago

  • Status changed from Unreviewed to In Topic Branch Pending Review

Available in my (reinh) branch “ticket/master/4670”

#2
Updated by James Turnbull over 1 year ago

  • Target version set to 2.7.x

#3
Updated by James Turnbull about 1 year ago

  • Assignee changed from Rein Henrichs to Nigel Kersten
  • Branch set to https://github.com/reinh/puppet/tree/ticket/master/4670

Used to belong to Rein…

Also available in: Atom PDF