Bug #4649

fcntl doesn't work on windows

Added by William Van Hevelingen over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:08/29/2010
Priority:High Due date:
Assignee:Markus Roberts % Done:

0%
Category:windows
Target version:2.6.2
Affected Puppet version:2.6.0 Branch:http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4649
Keywords:
Votes: 2

Description

puppet/ralsh crashes on calls to fcntl when running on windows

Excerpt from http://ruby-doc.org/stdlib/libdoc/fcntl/rdoc/index.html

“Fcntl loads the constants defined in the system‘s <fcntl.h> C header file, and used with both the fcntl(2) and open(2) POSIX system calls.”

And since windows doesn’t use posix it fails

Attached is all the places that grep found fnctl

fnctl_locations (1.3 kB) William Van Hevelingen, 08/29/2010 12:52 am

Related issues

related to Puppet - Bug #12725: Can't kick a windows agent Closed 02/20/2012
related to Puppet - Refactor #4862: Only a small portion of the vendored event-queue library ... Closed 09/28/2010
duplicated by Puppet - Bug #4812: Windows puppet puppetd - puppet version 2.6.1 installed f... Duplicate 09/21/2010

History

#1
Updated by James Turnbull over 1 year ago

  • Category set to windows
  • Affected Puppet version set to 2.6.0

#2
Updated by James Turnbull over 1 year ago

  • Target version set to 2.6.2

#3
Updated by James Turnbull over 1 year ago

  • Status changed from Unreviewed to Accepted

#4
Updated by Jesse Wolfe over 1 year ago

  • Target version changed from 2.6.2 to 2.7.x

#5
Updated by James Turnbull over 1 year ago

  • Priority changed from Normal to High
  • Target version changed from 2.7.x to 2.6.2

#6
Updated by Markus Roberts over 1 year ago

  • Assignee set to Markus Roberts

#7
Updated by Markus Roberts over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4649

The commit simple avoids setting the unsupported flags in environments where they are unsupported. Code review and some testing indicate that they aren’t actually needed for the restricted subset of event-queue that we are using. A more significant refactor is probably warranted, but isn’t appropriate for a point-point release.

#8
Updated by Markus Roberts over 1 year ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

#9
Updated by Markus Roberts over 1 year ago

  • Status changed from Ready For Checkin to Closed

Pushed to 2.6.x as commit:25738726526c6618906eb02878f32bb276fec26f

Also available in: Atom PDF