Bug #4605

Application should use the timezone and format set in a site-specific configuration

Added by Igal Koshevoy over 1 year ago. Updated about 1 year ago.

Status:Closed Start date:08/24/2010
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:1.1.0
Keywords:roadmapped Affected URL:
Branch: Affected Dashboard version:
Votes: 0

Description

Currently:

  • Timezone is set in config/environment.rb and this file must be edited to alter it. This is bad because this file is versioned and is part of the app. Worse still, not everything in the application uses it — such as Status::by_interval uses the timezone that’s set on the operating system instead.
  • Time/date formats are set in config/initializers/time_formats.rb. These now use international format, but we should accommodate people with other preferences.
  • Charts use their own format, ignoring the timezone and formatting used in the rest of the application.

Desired behavior:

  • Site-wide settings should be implemented, see #4604
  • Timezone setting should be added to the site-wide settings
  • Date-time format setting should be added to the site-wide settings
  • Everything should use the timezone settings, e.g. the views, Status::by_interval, charts, etc.
  • Everything should use the date-time formatting settings, e.g. the Rails views and charts.

Related issues

related to Puppet Dashboard - Feature #4606: Application should use browser's timezone for displaying ... Accepted 08/24/2010
related to Puppet Enterprise (Public) - Bug #6625: dashboard-1.0.4 should be aware of puppet server system t... Accepted 03/07/2011
related to Puppet Dashboard - Feature #4401: Chart dates should use same timezone as server Closed 07/30/2010
related to Puppet Dashboard - Feature #5180: Provide a configuration framework Closed 11/02/2010
related to Puppet Dashboard - Bug #4794: Dates and times in views should be shown in current Rails... Closed 09/17/2010
blocked by Puppet Dashboard - Feature #4604: Application should have a place for the site-specific set... Closed 08/24/2010

History

#1
Updated by Igal Koshevoy over 1 year ago

  • Status changed from Unreviewed to Accepted
  • Target version set to 1.0.5

#2
Updated by Igal Koshevoy over 1 year ago

  • Subject changed from Application should have a place for setting the site-specific time, and app should use it to Application should use the timezone and format set in a site-specific configuration

#3
Updated by Igal Koshevoy over 1 year ago

I rewrote the issue description to more clearly explain the current situation and desired behavior, and added the requirements that the date-time format be configurable.

#4
Updated by Nigel Kersten over 1 year ago

  • Keywords set to roadmapped

#5
Updated by Matt Robinson over 1 year ago

  • Status changed from Accepted to Merged - Pending Release

commit:dee7663e7541e5cb65cb1a63145679acda3d786b

#6
Updated by Paul Berry over 1 year ago

  • Status changed from Merged - Pending Release to Code Insufficient

Looks like the chart date format didn’t get updated. Nick and I will work on this ASAP.

#7
Updated by Jesse Wolfe over 1 year ago

  • Status changed from Code Insufficient to Closed

Merged into next as commit:d2299da5b6b89459deb196e0524b991d4aec060d

Merged into master in commit:4c484f2a6a6f627d4b8926404ca179ed373cb9cc as part of Iteration-2010-11-17

#8
Updated by James Turnbull about 1 year ago

  • Target version changed from 1.0.5 to 1.1.0

Also available in: Atom PDF