Bug #4574

Errors should be displayed in a useful way when called from the external_node tool

Added by Igal Koshevoy almost 2 years ago. Updated over 1 year ago.

Status:Closed Start date:08/20/2010
Priority:Normal Due date:
Assignee:Igal Koshevoy % Done:

0%
Category:-
Target version:1.0.4
Keywords: Affected URL:
Branch:http://github.com/igal/puppet-dashboard/tree/bug-4574-useful-node-classification-errors Affected Dashboard version:
Votes: 0

Description

The tool currently displays “500 Server Error” if there’s a parameter conflict, loop, etc — which isn’t useful.

The tool can be used in two ways, each of which may need special handling:

  1. Displaying the index if it’s not given any parameters, it probably shouldn’t display any nodes that are suffering errors. However, how should the errors be displayed so that the admin can find out about them?
  2. Displaying an individual node if given as a parameter, it should probably display an error, e.g. 409 Conflict.

History

#1
Updated by Igal Koshevoy almost 2 years ago

  • Assignee set to Nick Lewis

Nick: I’m assigning this to you per our discussion today. Because this is important for v1.0.4 and fairly small, please prioritize work on this. If you’re not sure how to to return the desired document, please report the results of your investigation about the right behavior and let me either implement the fix or work with you on it. Thanks!

#2
Updated by Igal Koshevoy almost 2 years ago

  • Status changed from Accepted to Investigating
  • Assignee deleted (Nick Lewis)

Nick: Sorry, I wrote the wrong message into the wrong ticket. I’m unassigning this so either of us can grab it after we’re done with our other v1.0.4 tasks.

#3
Updated by Nick Lewis over 1 year ago

  • Status changed from Investigating to Accepted
  • Assignee set to Nick Lewis

#4
Updated by Nick Lewis over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Nick Lewis to Igal Koshevoy
  • Branch set to http://github.com/nicklewis/puppet-dashboard/tree/bug-4574-useful-node-classification-errors

The only error supported for now is ParameterConflictError, but now there’s a reasonable place to put future error handling. It will print a message listing the failed parameters, which the external node tool will now accept. Puppet will log the error message from the external node tool.

#5
Updated by Igal Koshevoy over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed
  • Branch changed from http://github.com/nicklewis/puppet-dashboard/tree/bug-4574-useful-node-classification-errors to http://github.com/igal/puppet-dashboard/tree/bug-4574-useful-node-classification-errors

Nick:

Had to cherry pick the changes because they were in the midst of other unrelated changes. Possibly something went wrong with a rebase somewhere? However, the changes were fine.

Reviewed the changes with Jacob. Merged into next.

Also available in: Atom PDF