Bug #4531
Report times should use the "time" field, not the "created_at" field
| Status: | Closed | Start date: | 08/13/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Igal Koshevoy |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 1.0.4 | |||
| Keywords: | Affected URL: | |||
| Branch: | http://github.com/nicklewis/puppet-dashboard/tree/bug-4531-reports-use-actual-reported-time | Affected Dashboard version: | ||
| Votes: | 0 |
Description
This is another simple family of bugs that I’d like to fix in 1.0.4:
The “time” field is a time that the client created the report. The “created_at” field is the time that the Dashboard imported the report. These will probably be similar if using live report aggregation, but if you’re importing reports from YAML files, these will be wildly off.
Search for “created_at” in the source code and replace any unintended uses of this method on Report objects.
This is the cause of various bugs where reports were misordered, because these would be shown in order they were imported, rather than reported.
History
Updated by Nick Lewis almost 2 years ago
- Assignee set to Nick Lewis
Updated by Nick Lewis almost 2 years ago
- Status changed from Accepted to In Topic Branch Pending Review
- Branch set to http://github.com/nicklewis/puppet-dashboard/tree/bug-4531-reports-use-actual-reported-time
I found two cases of this, which were generating the run_time chart, and determining how long ago a success or failure was.
Updated by Nick Lewis almost 2 years ago
- Assignee changed from Nick Lewis to Igal Koshevoy
Updated by Igal Koshevoy almost 2 years ago
- Status changed from In Topic Branch Pending Review to Closed
Nick: I’ve reviewed and validated this patch. Thanks!