Puppet

Both hosts have indeed a sudoers file, if you throw it away Puppet works fine on both nodes, it goes wrong on the second, third… run on one of the nodes. I’ve attached the configurations. Please tell me if you need more.

It looks like what was happening was this: Puppet agent was looking in the local directory for a file with a name matching the name of an existing module (in this case “sudoers”). It was interpreting this file as a module definition, even if it did not have an extension. This shouldn’t be allowed.

Puppet agent shouldn’t be trying to read module files from the local machine at all. However, as a band aid fix, we’ve prevented puppet from trying to load module definitions from files that don’t have an extension. This should prevent it from mistaking the “/etc/sudoers” file as a module definition file.

More to come.

commit:449315a2c705df2396852462a1d1e14774b9f117 [#4397]+[#4344] Move type-name resolution out of Puppet::Resource into the AST

commit:daa801b9ff8c81e6812a08a3f6ef82f593248e9d [#4344] Temporary fix to stop agent from importing modules

commit:00ebf01227745edc84084d10a9d8be7439551b0f [#4344] Fix for failing templates when module name matches file in local dir.

This fix breaks/improves import so that it will now only import files named .pp or .rb where in the past it would happily have imported anything matching the supplied glob:

import "/etc/puppet/manifests/nodes/*"

This now only imports .pp and .rb not * as it’s asked to do.

This is a distinct issue, which I’ve opened as #4732.