Refactor #4308

Remove puppettest from spec_helper

Added by Matt Robinson almost 2 years ago. Updated over 1 year ago.

Status:Closed Start date:07/20/2010
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:testing
Target version:2.6.1
Affected Puppet version:2.6.0 Branch:http://github.com/mmrobins/puppet/tree/ticket/master/4308-remove_puppettest_from_specs
Keywords:
Votes: 0

Description

puppettest.rb is used for unit tests and loads and requires everything under the sun in the unit test directory. spec_helper was just requiring puppettest which means it got a lot of stuff loaded for all the specs that wasn’t necessary.

There have been a few tests in the past were unexpected things in the spec_helper or puppettest had caused problems, and cleaning unnecessary code out of those files makes it easier to reason about what the tests are doing.

History

#1
Updated by Matt Robinson almost 2 years ago

  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Branch set to http://github.com/mmrobins/puppet/tree/ticket/master/1234-remove_puppettest_from_specs

#2
Updated by Matt Robinson almost 2 years ago

  • Branch changed from http://github.com/mmrobins/puppet/tree/ticket/master/1234-remove_puppettest_from_specs to http://github.com/mmrobins/puppet/tree/ticket/master/4308-remove_puppettest_from_specs

#3
Updated by James Turnbull over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed

Pushed in commit:18d350b1a68b9d671f449d9a549b6c8f8636a7b8 in 2.6.x

#4
Updated by Matt Robinson over 1 year ago

  • Status changed from Closed to Re-opened
  • Assignee changed from Matt Robinson to James Turnbull

Hey James, I’m not seeing the SHA1 you mentioned in any branch. Did this actually get pushed?

Also in #4660 you thought that this ticket caused the test errors you were seeing with autotest, but that wasn’t the case. It was caused by #4298 which now errors if the manifest file in puppet apply doesn’t exist. Before it would just run silently, and the arguments it was getting were the arguments passed to autotest, which is what caused the autotest errors once #4298 went in. (I’m putting this note in #4660 also)

#5
Updated by James Turnbull over 1 year ago

  • Status changed from Re-opened to Closed

Sorry – did not tell you we’d worked out your patch wasn’t at fault. ;)

Pushed in commit:07d0be4684f75e6edc6fbb5d1397dd79b8ca2b6b

Also available in: Atom PDF