Puppet

This is getting more and more annoying, I looked at the code and removed managing rundir from it, because I can’t think of a good reason to manage this directory anyways. Here is the patch.

diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb
index 318ff41..7431b0d 100644
--- a/lib/puppet/defaults.rb
+++ b/lib/puppet/defaults.rb
@@ -24,11 +24,6 @@ module Puppet
         this directory can be removed without causing harm (although it
         might result in spurious service restarts)."
     },
-    :rundir => {
-      :default => Puppet.run_mode.run_dir,
-      :mode => 01777,
-      :desc => "Where Puppet PID files are kept."
-    },
     :genconfig => [false,
       "Whether to just print a configuration to stdout and exit.  Only makes
       sense when used interactively.  Takes into account arguments specified

For reference, we talked about this a little on puppet-dev a while back, as we didn’t want the 1777 perms in the Fedora/EPEL packages. http://groups.google.com/group/puppet-dev/browse_thread/thread/d75819c3f4f7f37c/

Thinking about this a little more, would it be reasonable to make an install option to enable/disable this? That way it would be easier for packagers and other folks building from source to get the desired behaviour without each of us patching defaults.rb.

Perhaps something like the manageinternalpermissions option?

Perhaps. I was thinking of an install-time option instead of runtime because it seems like a once and done sort of thing. That, and if it’s needed in a config file, it makes updating rpm packages a little funny, since anyone that has modified the stock config won’t get the the updated config option automatically. We could add it manually to the puppet command line in the init script in that case, but that feels wrong.

(I’ve got no problem continuing to patch the defaults in the Fedora/EPEL packages. Just figure that if we can come up with a solution that works for more distros/systems/users, all the better.)