Bug #4006

Fix XMLRPCClient test errors - Retrieved certificate does not match private key

Added by Matt Robinson over 1 year ago. Updated about 1 year ago.

Status:Closed Start date:06/15/2010
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

0%
Category:testing
Target version:-
Affected Puppet version:0.25.5 Branch:http://github.com/mmrobins/puppet/tree/bug/0.25.x/4006-stub_method_introduced_while_reverting_2890_to_clean_up_test_failures
Keywords:revert test failure
Votes: 0

Description

When Markus reverted changes made by 2890 he reintroduced a method certificate_matches_key? that then caused failures in network/xmlrpc/client.rb. I just stubbed that method to return true since the failing tests weren’t trying to test that methods behavior.

Related issues

related to Puppet - Bug #2890: Puppetd: signed certificate retrieval "Retrieved certific... Closed 12/04/2009

History

#1
Updated by Matt Robinson over 1 year ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin
  • Branch set to http://github.com/mmrobins/puppet/tree/bug/0.25.x/4006-stub_method_introduced_while_reverting_2890_to_clean_up_test_failures

I’m still not clear who should be setting the ready for checkin on status or when that’s appropriate, but Markus reviewed this change so I’m going to set it as such.

#2
Updated by Matt Robinson over 1 year ago

This is just a test to see if replying to tickets via email updates the ticket

#3
Updated by Matt Robinson over 1 year ago

Wanted to mention that this should apply cleanly from 0.25.x to master to resolve test failures there too.

And yes, the email updates the ticket, it just takes a few minutes

#4
Updated by Markus Roberts over 1 year ago

Normally we set it to “Ready for testing” when we put the branch on the ticket and wait until it gets a +1 or two on the list, some testing, or both before bumping it to “Ready for Checkin” and preferably these are done by someone other than the person who put up the branch (checking your own work isn’t nearly as effective).

#5
Updated by James Turnbull over 1 year ago

  • Status changed from Ready For Checkin to Closed
  • Target version set to 49

Pushed in commit:0a0923c9636569fa5868ebd13233949cf90736f0 in branch 0.25.x

#6
Updated by James Turnbull about 1 year ago

  • Target version deleted (49)

Also available in: Atom PDF