Bug #3836

External nodes should only capture stdout

Added by Jonathan Booth about 2 years ago. Updated 11 months ago.

Status:Closed Start date:05/21/2010
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

0%
Category:plumbing
Target version:2.6.9
Affected Puppet version:0.25.4 Branch:https://github.com/ohookins/puppet/tree/ticket/2.6.x/3836
Keywords:
Votes: 2

Description

External Nodes doesn’t make any mention that puppet does STRANGE THINGS with standard out/error in your external nodes script — so you can’t just write standard unix shell scripting and expect it to work. As a sample — I had a ruby ssl warning error in my external nodes and spent a day trying to track it down. I’d used a wrapper script to dump standard error into the bit bucket… yet problems persisted. When I eliminated the ssl warning through other means, suddenly external nodes worked.

A note about “puppet captures ALL OUTPUT so don’t leave junk on standard error that would mess up your YAML” would be great.

Related issues

duplicated by Puppet - Bug #4398: external node script does not ignore stderr Duplicate 07/29/2010

History

#1
Updated by Nigel Kersten about 2 years ago

I’d argue this is a bug rather than a documentation error.

The external node classifier should only capture stdout, ever.

#2
Updated by Anonymous almost 2 years ago

I agree with Nigel, this is a bug. anything on stderr should perhaps be logged, and/or should fail the operation.

#3
Updated by Anonymous almost 2 years ago

  • Project changed from Puppet Documentation to Puppet
  • Affected Puppet version set to 0.25.4

#4
Updated by James Turnbull almost 2 years ago

  • Tracker changed from Feature to Bug
  • Subject changed from External Nodes important clarification -- http://docs.puppetlabs.com/guides/external_nodes.html to External nodes should only capture stdout
  • Category set to plumbing
  • Status changed from Unreviewed to Accepted
  • Assignee set to Markus Roberts

#5
Updated by Oliver Hookins about 1 year ago

Available for testing in https://github.com/ohookins/puppet/tree/ticket/2.6.x/3836

#6
Updated by Oliver Hookins about 1 year ago

  • Branch set to https://github.com/ohookins/puppet/tree/ticket/2.6.x/3836

#7
Updated by Nigel Kersten about 1 year ago

Oliver, did this go out to the -dev list as well? Just trying to make sure it doesn’t fall through the cracks.

#8
Updated by Oliver Hookins about 1 year ago

Yes, it did get posted to the list, and was dutifully ignored ;) I guess my code can’t be bad enough to warrant a flaming…

http://groups.google.com/group/puppet-dev/browse_thread/thread/1a2e06f3f3097442

#9
Updated by Max Martin about 1 year ago

  • Status changed from Accepted to Merged - Pending Release

Merged into 2.6.next in commit:25eab1a5193762688cfa16d7bb750d9f962503c9

#10
Updated by James Turnbull 11 months ago

  • Status changed from Merged - Pending Release to Closed
  • Target version set to 2.6.9

Also available in: Atom PDF