Bug #3802

New zypher provider incorrectly referres to rug

Added by Markus Roberts about 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:05/18/2010
Priority:High Due date:
Assignee:Alpar Torok % Done:

0%
Category:provider
Target version:2.6.0
Affected Puppet version:development Branch:http://github.com/mmrobins/puppet/tree/bug/master/3802-zypper
Keywords:SUSE Zypper rug
Votes: 0

Description

The new zypher provider, as noted on #1223, contains code / comments that were just copy pasted from the old rug provider.

Related issues

related to Puppet - Bug #1223: rug not on OpenSuSE 10.3 anymore Closed

History

#1
Updated by Markus Roberts about 2 years ago

  • Keywords changed from SuSe Zypher rug to SuSe Zypper rug

#2
Updated by Matt Robinson about 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/mmrobins/puppet/tree/bug/master/3802-zypper

The change suggested by Alpar Torok in #1223 have been made and are available in the branch attached to this ticket. Unfortunately, he isn’t available to assign this ticket to, so hopefully he’s reading the dev list when the patch goes through so that he can test it. Also unfortunately, we can’t test this change without and OpenSuse setup sitting around. Rein and Jesse seem okay with leaving the process as is for now, but hopefully we’ll find an opportunity to develop a better one soon.

#3
Updated by Matt Robinson about 2 years ago

Matt Robinson wrote:

The change suggested by Alpar Torok in #1223 have been made and are available in the branch attached to this ticket. Unfortunately, he isn’t available to assign this ticket to, so hopefully he’s reading the dev list when the patch goes through so that he can test it. Also unfortunately, we can’t test this change without and OpenSuse setup sitting around. Rein and Jesse seem okay with leaving the process as is for now, but hopefully we’ll find an opportunity to develop a better one soon.

Update: if Alpar is added to the reviewer group we can assign this ticket to him and add him as a watcher. Markus has done the adding.

#4
Updated by Matt Robinson about 2 years ago

  • Assignee changed from Matt Robinson to Alpar Torok

Alpar, The change you suggested for fixing the zypper usage has been implemented on branch http://github.com/mmrobins/puppet/tree/bug/master/3802-zypper. Does that work for you? Thanks Matt

#5
Updated by Federico Lucifredi about 2 years ago

  • Keywords changed from SuSe Zypper rug to SUSE Zypper rug

#6
Updated by Alpar Torok about 2 years ago

ACK, i will test it as soon as i possible. Does it make sense to install the whole branch, or i can just test zypper.rb with my current install (0.25.4)?

#7
Updated by Matt Robinson about 2 years ago

Testing zypper.rb with your current install should be fine. zypper.rb wasn’t created in 0.25.x, but I assume if it works there it will work in the upcoming release. If not, please try installing the whole branch, but that probably won’t be necessary. Thanks

#8
Updated by Alpar Torok about 2 years ago

Tested the provider and works great

#9
Updated by Jesse Wolfe about 2 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

#10
Updated by Nick Lewis almost 2 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:0fc41aed7056e645f1d41a7ef6a00a34344dde38 in master

Also available in: Atom PDF