Bug #3740

Facter::Manufacturer.dmi_find_system_info doesn't split dmi output by sections

Added by Marc Fournier about 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:05/07/2010
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:library
Target version:1.5.8
Keywords: Affected Facter version:
Branch:http://github.com/mfournier/facter/tree/tickets/master/2341
Votes: 0

Description

Since #2341, dmi_find_system_info splits the dmidecode output on the string “/Handle/“, which was probably ment to be the regex /Handle/. Hence it doesn’t split anything anymore and tries to match the whole dmi output. So the function works in most cases, but when we are looking for an key which is found at several places, it returns the first one found instead of the one in the section we expect.

I have a patch I’ll submit in a moment.

History

#1
Updated by Marc Fournier about 2 years ago

  • Branch set to http://github.com/mfournier/facter/tree/tickets/master/2341

#2
Updated by James Turnbull about 2 years ago

  • Category set to library
  • Status changed from Unreviewed to Closed
  • Assignee set to James Turnbull
  • Target version set to 1.5.8

Pushed in commit:c5b8d3b9c2621649d0559ed87a3d5493d706288a in branch master.

#3
Updated by Paul Nasrat almost 2 years ago

Hmm I just pushed this I’m not sure James did

http://github.com/reductivelabs/facter/commit/e9a60bc1d403d280016402199a3d396078577d2c

Paul

Also available in: Atom PDF