Bug #3672

Puppet dies silently on duplicate module definition in fileserver.conf

Added by Jason Antman about 2 years ago. Updated about 2 years ago.

Status:Closed Start date:04/26/2010
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:fileserving
Target version:0.25.5
Affected Puppet version:0.25.4 Branch:
Keywords:fileserver fileserver.conf
Votes: 0

Description

If two modules are defined with the same name in fileserver.conf, Puppetmasterd 0.25.4 dies without a meaningful error.

/usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:286:in `raise': wrong number of arguments (ArgumentError)
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:286:in `readconfig'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:279:in `each'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:279:in `readconfig'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:276:in `open'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:276:in `readconfig'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/handler/fileserver.rb:124:in `initialize'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:139:in `new'
    from /usr/lib/ruby/site_ruby/1.8/puppet/network/http/webrick.rb:139:in `xmlrpc_servlet'
     ... 10 levels...
    from /usr/lib/ruby/site_ruby/1.8/puppet/application.rb:217:in `run'
    from /usr/lib/ruby/site_ruby/1.8/puppet/application.rb:306:in `exit_on_fail'
    from /usr/lib/ruby/site_ruby/1.8/puppet/application.rb:217:in `run'
    from /usr/sbin/puppetmasterd:66

Sample config file snippet generating the error:

[radius]
path /etc/puppet/main/modules/radius/files
allow 192.168.0.*
allow 10.0.1.*
allow 10.0.2.*
[xen]
path /etc/puppet/main/modules/xen/files
allow 192.168.0.*
allow 10.0.1.*
allow 10.0.2.*
[nagios]
path /etc/puppet/main/modules/nagios/files
allow 192.168.0.*
allow 10.0.1.*
allow 10.0.2.*
[edu_rutgers_css_hill-tb]
path /etc/puppet/main/modules/edu_rutgers_css_hill-tb/files
allow 192.168.0.*
allow 10.0.1.*
allow 10.0.2.*
[radius]
path /etc/puppet/main/modules/radius8021x/files
allow 192.168.0.*
allow 10.0.1.*
allow 10.0.2.*

History

#1
Updated by Jason Antman about 2 years ago

I guess I shouldn’t have said it dies “silently”… the included trace came from running puppetmasterd with —no-daemonize —verbose —debug. But this seems unhandled, and nothing shows up in the normal syslog output.

#2
Updated by James Turnbull about 2 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to James Turnbull
  • Target version set to 0.25.5

I’ll try to look at this sometime this week. Should be an easy fix.

#3
Updated by James Turnbull about 2 years ago

Actually I think it’s the error message that is kaputing. Something is wrong with the ‘raise’ that creates the intended error.

#4
Updated by James Turnbull about 2 years ago

Fixed mail to -dev list.

#5
Updated by James Turnbull about 2 years ago

  • Status changed from Accepted to Closed

Pushed in commit:e4130af8b035fc8f62561c01a092327d96d12658 in branch 0.25.x

Also available in: Atom PDF