Bug #3470

class-group UI widget: UI for assigning classes/groups should render correctly on Firefox

Added by Anonymous about 2 years ago. Updated over 1 year ago.

Status:Closed Start date:03/30/2010
Priority:Normal Due date:
Assignee:Igal Koshevoy % Done:

0%
Category:-
Target version:1.0.4
Keywords: Affected URL:
Branch:http://github.com/igal/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete Affected Dashboard version:
Votes: 0

Description

When adding a class to a node in Firefox (Here 3.6 on OS X Snow Lep.), weird things happen.

See attached screenshot.

Puppet_Node_Manager-3.jpg (41.1 kB) Anonymous, 03/30/2010 10:34 pm

dashboard-tag2.png (48.2 kB) Igal Koshevoy, 08/24/2010 07:16 pm

Related issues

related to Puppet Dashboard - Feature #3427: class-group UI widget: Classes and groups aren't saved un... Closed 03/26/2010

History

#1
Updated by Rein Henrichs about 2 years ago

  • Status changed from Unreviewed to Accepted

#2
Updated by James Turnbull about 2 years ago

  • Target version set to 1.0

#3
Updated by Rein Henrichs about 2 years ago

  • Target version changed from 1.0 to 1.1.0

I’d like to address this when I rewrite the autocomplete functionality for 1.1. Deferring unless anyone objects.

#4
Updated by David Schmitt almost 2 years ago

This also happens in Chrome. I also don’t think it makes sense to fix this in isolation, but the whole autocomplete thingy is really annoying.

#5
Updated by Rein Henrichs almost 2 years ago

We’re going to overhaul autocomplete for 1.1.0. I’m not happy with it either.

#6
Updated by Igal Koshevoy almost 2 years ago

  • Assignee deleted (Rein Henrichs)

#7
Updated by Igal Koshevoy almost 2 years ago

  • Target version changed from 1.1.0 to 1.0.5

#8
Updated by Igal Koshevoy almost 2 years ago

  • Subject changed from add class widget renders strangely in Firefox to UI for adding a class or group should render correctly on Firefox

#9
Updated by Igal Koshevoy almost 2 years ago

  • Subject changed from UI for adding a class or group should render correctly on Firefox to UI for assigning classes/groups should render correctly on Firefox

#10
Updated by Igal Koshevoy over 1 year ago

I’ve attached a screenshot of how this is misrendered on Firefox.

#11
Updated by Igal Koshevoy over 1 year ago

  • Subject changed from UI for assigning classes/groups should render correctly on Firefox to class-group UI widget: UI for assigning classes/groups should render correctly on Firefox

#12
Updated by Jacob Helwig over 1 year ago

  • Assignee set to Jacob Helwig

#13
Updated by Jacob Helwig over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Jacob Helwig to Igal Koshevoy
  • Branch set to http://github.com/jhelwig/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete

Igal,

I’ve pushed out a branch that should be ready for testing, which addresses this, #4635, and is a partial fix for #3427. This replaces the current fcbkcomplete.js with an alternative that does not have the rendering issues.

#14
Updated by Igal Koshevoy over 1 year ago

  • Status changed from In Topic Branch Pending Review to Accepted
  • Branch changed from http://github.com/jhelwig/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete to http://github.com/igal/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete

Pushed new branch with updated styling, had Jacob review it:

[#3470] Update token autocompletion interface to match previous styling.

We’ll do some more refactoring to reduce code duplication shortly.

#15
Updated by Igal Koshevoy over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review

Change of plan:

  1. For r1.0.4, we’ll do a final review of this code and merge it into ‘next’ soon and with few changes.
  2. For r1.0.5, we’ll do a refactoring to reduce duplication throughout the code base as #4674.

#16
Updated by Igal Koshevoy over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed
  • Target version changed from 1.0.5 to 1.0.4

Added a few more tests. Merged into ‘next’.

Also available in: Atom PDF