Feature #3427

class-group UI widget: Classes and groups aren't saved unless you click on them

Added by Dan Bode about 2 years ago. Updated over 1 year ago.

Status:Closed Start date:03/26/2010
Priority:High Due date:
Assignee:Igal Koshevoy % Done:

0%
Category:-
Target version:1.0.4
Keywords:usability Affected URL:
Branch:http://github.com/igal/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete Affected Dashboard version:
Votes: 1

Description

Specifying the name of the class or group to be added is not sufficient (like with parameters), you must select the item from (the Ajaxy) dropdown box. Classes and groups that are specified in the field should be added when saved is selected regardless of rather the dropdown is selected.

Related issues

related to Puppet Dashboard - Bug #3470: class-group UI widget: UI for assigning classes/groups sh... Closed 03/30/2010
duplicated by Puppet Dashboard - Bug #3463: Clicking "save" without clicking on autocompleted class d... Duplicate 03/30/2010
duplicated by Puppet Dashboard - Feature #3429: Dashboard should show an error if an invalid group/class ... Duplicate 03/26/2010

History

#1
Updated by Rein Henrichs about 2 years ago

  • Status changed from Unreviewed to Accepted

#2
Updated by Teyo Tyree almost 2 years ago

  • Priority changed from Normal to High
  • Target version set to 1.1.0
  • Keywords set to usability

#3
Updated by Igal Koshevoy almost 2 years ago

  • Target version changed from 1.1.0 to 1.0.5

#4
Updated by Igal Koshevoy almost 2 years ago

  • Subject changed from groups/classes are not added unless they are selected from the dropdown box. to UI for assigning groups/classs doesn't add them unless they are selected from the dropdown box.

#5
Updated by Igal Koshevoy over 1 year ago

  • Subject changed from UI for assigning groups/classs doesn't add them unless they are selected from the dropdown box. to class-group UI widget: Classes and groups aren't saved unless you click on them

#6
Updated by Jacob Helwig over 1 year ago

  • Assignee set to Jacob Helwig

#7
Updated by Jacob Helwig over 1 year ago

  • Branch set to http://github.com/jhelwig/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete

I have a partial fix for this in the branch for #3470. It does not address the case where a user directly clicks on “Save Changes”, before a class/group has been added to the textbox. However, it does automatically add the currently highlighted class/group if focus is lost from the textbox (click anywhere else on the page, or tab away from the field).

#8
Updated by Igal Koshevoy over 1 year ago

  • Status changed from Accepted to Needs Decision
  • Assignee changed from Jacob Helwig to Igal Koshevoy

We need to decide if the solution that Jacob proposed enough to fulfill the requirements.

#9
Updated by Igal Koshevoy over 1 year ago

  • Status changed from Needs Decision to Closed
  • Target version changed from 1.0.5 to 1.0.4
  • Branch changed from http://github.com/jhelwig/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete to http://github.com/igal/puppet-dashboard/tree/bug-3470-replace-fcbkcomplete

Reviewed the code and tested it with IE7, Firefox 3, Firefox 4, Opera and Chrome. Merged into ‘next’.

I’m accepting this code because it works well and matches the way most people would expect this widget to work.

The edge case of activating a search and clicking the “submit” button is worth knowing about, but it’s unlikely that many people would expect this to work. If that edge case becomes a problem, we can create a new ticket to address this in the future.

Also available in: Atom PDF