Bug #3378

pkgdmg.rb should be able to handle a flat pkg installer

Added by Allan Marcus about 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:03/17/2010
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

0%
Category:Darwin
Target version:2.6.0
Affected Puppet version:0.25.4 Branch:http://github.com/amrset/puppet/branches/feature/master/3378
Keywords:
Votes: 0

Description

The new installers from Apple are “flat”, that is to say they are no longer folders. the pkgdmg.rb should allow the user of a .pkg installer directly if the installer is a file and not a folder.

Please let me know if you nee further information.

flatpackage.patch (5.5 kB) Roy Nielsen, 03/24/2010 02:56 am

Related issues

duplicated by Puppet - Feature #3405: add "flat package" support to the Mac pkgdmg package prov... Duplicate 03/22/2010

History

#1
Updated by Nigel Kersten about 2 years ago

I think you need to flesh out the request a bit more.

Are you saying you want the pkgdmg provider to look at the url, and if it ends in .pkg, then assume it is a flat package that can be installed as is?

#2
Updated by Allan Marcus about 2 years ago

Yes. The documentation would need to specify that a pkg file in the “source” must be a flat package.

#3
Updated by Nigel Kersten about 2 years ago

So that’s probably a pretty simple patch. If you’re interested in writing this, I’m happy to mentor you through it.

#4
Updated by Roy Nielsen about 2 years ago

Hello,

I’ve put a patch together for the pkgmdg package provider and it’s (spec/unit/provider/package/pkgdmg.rb) test – it’s attached. I hope the patch is formatted right – I used “git diff master > flatpackage.patch” from the http://projects.reductivelabs.com/projects/puppet/wiki/Development_Development_Lifecycle .

Regards, -Roy

#5
Updated by Markus Roberts about 2 years ago

  • Status changed from Unreviewed to Accepted

#6
Updated by Markus Roberts about 2 years ago

  • Tracker changed from Bug to Feature

#7
Updated by Markus Roberts about 2 years ago

  • Tracker changed from Feature to Bug
  • Target version set to 2.6.0

As per Nigel in discussion on the list. As an aside, this is yet another case were having the providers asynchronous would let us be more agile.

#8
Updated by Nigel Kersten about 2 years ago

  • Status changed from Accepted to Ready For Checkin

+1 for me.

#9
Updated by Roy Nielsen about 2 years ago

I’ve finally got it up on github:

www.github.com/amrset/puppet

switch branch to feature/master/3378

new code: http://github.com/amrset/puppet/blob/feature/master/3378/lib/puppet/provider/package/pkgdmg.rb & http://github.com/amrset/puppet/blob/feature/master/3378/spec/unit/provider/package/pkgdmg.rb

Regards, -Roy

#10
Updated by Roy Nielsen about 2 years ago

Hello,

So does “ready for checkin” mean it’ll make it into rowlf?

Thanks, -Roy

#11
Updated by James Turnbull about 2 years ago

Yep. :)

#12
Updated by Roy Nielsen about 2 years ago

Cool Beans!

-Roy

#13
Updated by James Turnbull about 2 years ago

  • Status changed from Ready For Checkin to In Topic Branch Pending Review
  • Assignee set to Markus Roberts

#14
Updated by Markus Roberts about 2 years ago

  • Branch set to http://github.com/amrset/puppet/branches/feature/master/3378

Putting the branch in the branch field

#15
Updated by Markus Roberts about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

#16
Updated by Markus Roberts almost 2 years ago

  • Status changed from Merged - Pending Release to Closed

In master as commit:eafde5cacaac79da79d9d1415618801fcc37edcc

Also available in: Atom PDF