Puppet

Dan Bode wrote:

I have an example where require is not correctly specifying a dependency between classes. [snip] I can work around by specifying require=>Class[‘mysql::server’] for the resources that care about order, but I would rather use require.

I think the error is the following:

err: //redmine::mysql/Database[redmine]: Failed to retrieve current state of resource: Provider mysql is not functional on this platform

I’m not familiar with the RAL, but maybe “suitability” is resolved before ordering takes place?

Did you try to individually use “require=>Class[‘mysql::server’]”? If it doesn’t work either, then that’s the root cause.

yes, explicitly adding the require => Class[mysql::server] stuff fixes this issue. (orders things correctly, things work)

Although the resolving stuff looks suspicious its def not the root cause, that error only occurs if mysql has not been installed before the type is used (I have been hacking around with this loading/order stuff). In the same manifest, I found more places where require class isnt creating the dependencies.

also, this is when using the puppet executable (not sure if that should matter), I havent had a change to check it with puppetd.

Dan Bode wrote:

yes, explicitly adding the require => Class[mysql::server] stuff fixes this issue. (orders things correctly, things work)

Although the resolving stuff looks suspicious its def not the root cause, that error only occurs if mysql has not been installed before the type is used (I have been hacking around with this loading/order stuff). In the same manifest, I found more places where require class isnt creating the dependencies.

also, this is when using the puppet executable (not sure if that should matter), I havent had a change to check it with puppetd.

would you have a simpler manifest exhibiting the problem (ie one not dependent of a type/provider I don’t have access to)?

Dan Bode wrote:

yes, explicitly adding the require => Class[mysql::server] stuff fixes this issue. (orders things correctly, things work)

Although the resolving stuff looks suspicious its def not the root cause, that error only occurs if mysql has not been installed before the type is used (I have been hacking around with this loading/order stuff). In the same manifest, I found more places where require class isnt creating the dependencies.

also, this is when using the puppet executable (not sure if that should matter), I havent had a change to check it with puppetd.

It would be interesting to use —graph and have a look to the resulting graph to see if there is indeed a relationship.

I believe I have narrowed this to a small test case:

class foo {
  require bar, baz
  notify { 'foo': }
}
class bar {
  notify { 'bar': }
}
class baz {
  notify { 'baz': }
}
node default {
  include foo
}

The problem seems to be using require for more than one class.. it will include all the classes, but only the last one actually becomes a dependency. In the debug output I see “//foo/require: requires Class[baz]” but no line for Class[bar]. Since the recipe code in the issue description above uses require for more than one class, I think this may be the source of the issue.

Alan Harder wrote:

I believe I have narrowed this to a small test case: […]

The problem seems to be using require for more than one class.. it will include all the classes, but only the last one actually becomes a dependency. In the debug output I see “//foo/require: requires Class[baz]” but no line for Class[bar]. Since the recipe code in the issue description above uses require for more than one class, I think this may be the source of the issue.

Thanks Alan, I think you found the exact problem. I’ll try to come with a fix during the week-end.

Fix looks good to me. I applied just the one line change to 0.25.4 and I see resources in the right order with both: require bar, baz or require bar require baz I also see mention of both class dependencies in the —debug output.