Puppet

I don’t have access to a sun setup and was unable to reproduce the analog of this with another provider. Also, I note that this is an incomplete example, in that there’s no name given for the package, which should prevent it from getting as far as it would need to to generate the indicated error.

Oops, yes I did miss the resource name.. and that is an important factor. If it is a package name that does not exist on the system, the error is ok:

err: //Node[]/Package[test]/ensure: change from absent to latest failed: Could not update: Execution of '/usr/sbin/pkgadd -d /bogus/path -n test' returned 99: pkgadd: ERROR: attempt to process datastream failed
    - open of  failed, errno=2
pkgadd: ERROR: could not process datastream from 
 at /etc/opt/csw/puppet/manifests/nodes.pp:14

But if the package does exist on the system (so it needs to compare the version number), then it gets the nil:NilClass error. Any other information I can provide? I updated to today’s 0.25.x branch from git and still see this.

I looked at info2hash in provider/package/sun.rb, and tried changing “return nil” to “return {}” in the rescue block for Puppet::ExecutionFailure. This avoided the nil:NilClass error, and instead I got:

debug: //Node[]/Package[]/ensure:  "" is installed, latest is nil

It then preceded to pkgrm the package.. so this behavior isn’t great either. Would be better to report the error in determining the version of the given package source, and abort before doing pkgrm of the existing package.

Thanks for the info that should be enough for us to track it down (and if not, we’ll ask for more).

Instead of returning anything it should now generate a more informative / specific message and abort that resource.

Here’s the output I get now:

debug: Package[CSWfacter](provider=sun): Executing '/usr/bin/pkginfo -l -d /bogus/path CSWfacter'
err: //Node[]/Package[CSWfacter]: Failed to retrieve current state of resource: Could not get latest version: Unable to get information about installed version of package CSWfacter, if any because of: #

Behavior is good.. message mentions “installed version”, though it actually failed to get the new/package version, not the installed version. The IO:0xf98e20 thing isn’t too helpful, but that’s ok. Thanks!

Updated with a revised message.

Looks great!

debug: Package[CSWfacter](provider=sun): Executing '/usr/bin/pkginfo -l -d /bogus/path CSWfacter'
err: //Node[]/Package[CSWfacter]: Failed to retrieve current state of resource: Could not get latest version: Unable to get information about package CSWfacter because of: pkginfo: ERROR: unable to complete package transfer
    - unable to obtain package volume

Pushed in commit:“0e5d2647bd5f515dbaacf45f9e7dda5c27eb465a” in branch 0.25.x