Bug #2929

File rucurse true, checksums all the files with md5

Added by Silviu Paragina 9 months ago. Updated 4 months ago.

Status:Closed Start:12/14/2009
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

0%
Category:-
Target version:0.25.5
Affected version:0.25.1 Branch:http://github.com/masterzen/puppet/tree/tickets/0.25.x/2929
Keywords:
Votes: 2

Description

Not sure if this is a bug or a feature. On some ways it might be considered a feature.

Take this example:

        file
        { "imagedir":
                path    => "/var/lib/images",
                ensure  => "directory",
                recurse => true,
                owner   => "root",
                group   => "root",
                mode    => 700,
        }

All the files inside the dir would get checksummed with md5, which might not be the best choice. First of all I don’t see any reason for this to happen in the above case. The best choice would be to respect the dir’s checksum type, as it isn’t honored, if it is set.

Related issues

related to Puppet - Refactor #2630: Sourced files are checksummed twice Accepted 09/13/2009
related to Puppet - Bug #2899: puppetd checks client files recursively even if they aren... Investigating 12/08/2009
related to Puppet - Feature #3170: Please re-introduce checksum => nosum for file resources Accepted 02/09/2010

History

#1
Updated by Markus Roberts 9 months ago

  • Status changed from Unreviewed to Accepted
  • Target version set to 2.6.0

#2
Updated by Brice Figureau 6 months ago

  • Status changed from Accepted to Ready for Testing
  • Assignee set to Markus Roberts
  • Branch set to http://github.com/masterzen/puppet/tree/tickets/0.25.x/2929

The current branch fixes two thing:

  • it prevents md5 checksumming of locally managed files (as this tickets addresse), when using “checksum => none” (tickets #3170)
  • it also optimize a bit the way change events are propagated when managing generated sub resources.

#3
Updated by Markus Roberts 5 months ago

  • Status changed from Ready for Testing to Available In Testing Branch

#4
Updated by Markus Roberts 5 months ago

  • Status changed from Available In Testing Branch to Needs design decision
  • Target version changed from 2.6.0 to 0.25.5

This patch has been applied in master for Rowlf.

9122ac51284086a050d61df8fe060616aaf83d3c Fix #2929 – Allow checksum to be “none”

If it’s going it 0.25.5, it needs to be marked “Ready for Checkin”; otherwise “Closed”

#5
Updated by Jesse Wolfe 5 months ago

  • Status changed from Needs design decision to Ready for Checkin

Ready for Checkin for 0.25.x

#6
Updated by James Turnbull 5 months ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“19863c07f983ec181fb81c797ee8b9c8d335e18c” in branch 0.25.x

Also available in: Atom PDF